[samigo-team] SAM-1641: float comparison issues

[David Horwitz]

Hi Guys,

Sorry about that I seem to have dropped the ball pretty baddly one that 
one. I will go through them ASAP.

I suspected they where a contributing factor to the excessive re-saving 
of answers as students took the test (i.e. an update was issued on each 
answer each time a student took the test).

Seem I owe many members of this group a drink next time we meet up


D

On 09/11/2012 05:28 PM, Sam Ottenhoff wrote:
> Dave H and others,
>
> Can you please review your commits on SAM-1641 
> (https://jira.sakaiproject.org/browse/SAM-1641)?
>
> This ticket was related to Findbugs finding issues with float 
> comparison using ==.  Your commits use MathUtils instead.  It seems 
> like you also inverted the logic from not equals to equals in 5 of the 
> 6 cases.  Earle has cleaned these up in 
> https://jira.sakaiproject.org/browse/SAM-1726 but can you take another 
> look to confirm the fixes?
>
> Findbugs can be a useful tool, and I happen to think these float 
> comparison issues might be relevant to some scoring issue research I 
> am doing, but inverting the logic on 5 of 6 equals checks means 5 
> separate regressions that need to be cleaned up.
>
> --Sam
>
>
> _______________________________________________
> samigo-team mailing list
> samigo-team at collab.sakaiproject.org
> http://collab.sakaiproject.org/mailman/listinfo/samigo-team

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://collab.sakaiproject.org/pipermail/samigo-team/attachments/20120912/78bd81da/attachment.html