[samigo-team] SAM-1724: NPE in grading

[Sam Ottenhoff]

https://jira.sakaiproject.org/browse/SAM-1724

I'm a bit worried about the continue if null that was checked in on
SAM-1724.  I agree we need more null checking here, but what are the
ramifications of doing a continue when we are grading?

Does anyone have an idea how this item can be null?

  ItemDataIfc item = (ItemDataIfc) publishedItemHash.get(itemId);

Here is the stack trace posted on SAM-1724:

caused by: java.lang.NullPointerException
    at
org.sakaiproject.tool.assessment.services.GradingService.storeGrades(GradingService.java:808)
    at
org.sakaiproject.tool.assessment.services.GradingService.storeGrades(GradingService.java:707)
    at
org.sakaiproject.tool.assessment.ui.listener.delivery.SubmitToGradingActionListener.persistAssessmentGrading(SubmitToGradingActionListener.java:364)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://collab.sakaiproject.org/pipermail/samigo-team/attachments/20120912/a8a2b1a9/attachment.html