[samigo-team] SAM-1641: float comparison issues

[Sam Ottenhoff]

Dave H and others,

Can you please review your commits on SAM-1641 (
https://jira.sakaiproject.org/browse/SAM-1641)?

This ticket was related to Findbugs finding issues with float comparison
using ==.  Your commits use MathUtils instead.  It seems like you also
inverted the logic from not equals to equals in 5 of the 6 cases.  Earle
has cleaned these up in https://jira.sakaiproject.org/browse/SAM-1726 but
can you take another look to confirm the fixes?

Findbugs can be a useful tool, and I happen to think these float comparison
issues might be relevant to some scoring issue research I am doing, but
inverting the logic on 5 of 6 equals checks means 5 separate regressions
that need to be cleaned up.

--Sam
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://collab.sakaiproject.org/pipermail/samigo-team/attachments/20120911/50412696/attachment.html