[samigo-team] Regression: number formats of Numeric answers

[Karen Tsao]

I made a fix which basically adds back the related lines that have been
removed. Now the comma works as period. As there is not much time, I only
did some simple tests. Can we get some QA help to perform detailed
regression tests as SAM-1221 contains couple of different scenarios.

Thanks,
Karen

On Thu, Sep 6, 2012 at 10:50 AM, David Horowitz <david.horwitz at uct.ac.za>wrote:

> Unfortunately didn't have a chance to look into it today. The fix I had
> seemed to break the si notation reading. Hence the unit tests I put in trunk
>
> Sent from my iPad
>
> On 06 Sep 2012, at 7:02 PM, Karen Tsao <ktsao at stanford.edu> wrote:
>
> Hi David,
>
> Any progress in https://jira.sakaiproject.org/browse/SAM-1793? As Mathew
> pointed out, your fix is a better solution, can you let me know why you
> reverted it? I can take over the remaining work if we are on the right
> track.
>
> Thanks,
> Karen
>
> On Wed, Sep 5, 2012 at 10:22 AM, David Horowitz <david.horwitz at uct.ac.za>wrote:
>
>> Hi Karen,
>>
>> I committed a change set against 1221 that includes a unit test for the
>> common cases and 1 for the broken case commented out. The change set I
>> committed to uct msub seems to break other things.
>>
>> I will check in the morning
>>
>> D
>>
>> Sent from my iPad
>>
>> On 05 Sep 2012, at 7:03 PM, Karen Tsao <ktsao at stanford.edu> wrote:
>>
>> Hi David,
>>
>> I see what you mean. I will look into this now. But as SAM-1221 is
>> contributed by UPV, I will contact them to see if they can provide a fix
>> sooner.
>>
>> By the way, do you have any test case set because SAM-1221 can have many
>> different combinations. I want to be able to cover all of them.
>>
>> Thanks,
>> Karen
>>
>> On Wed, Sep 5, 2012 at 4:51 AM, David Horwitz <david.horwitz at uct.ac.za>wrote:
>>
>>> Hi All,
>>>
>>> I seem to have found a serious regression in 2.9:
>>>
>>> https://jira.sakaiproject.org/browse/SAM-1793
>>>
>>> it seems to have been introduced by SAM-122 (support for scientific
>>> notation)
>>>
>>> In 2.8 and prior either a comma or a full stop could be used to denote a
>>> decimal separator. The UI still lists the comma as a valid separator
>>> outside of scientific notation. However gradingService.validate only
>>> accepts a full stop.
>>>
>>> In the case of an upgraded system it means that any students answers
>>> with a comma will lead to an unhandled exception.
>>>
>>> Do we need a complex upgrade to fix all answers (and a fix to the UI
>>> docs) or is the method buggy?
>>>
>>> Regards
>>>
>>> David
>>> _______________________________________________
>>> samigo-team mailing list
>>> samigo-team at collab.sakaiproject.org
>>> http://collab.sakaiproject.org/mailman/listinfo/samigo-team
>>>
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://collab.sakaiproject.org/pipermail/samigo-team/attachments/20120906/bd2d434b/attachment.html