[samigo-team] SAM-1615: ready to commit?

[David Horwitz]

Hi

I did this to avoid a circular dependency between API and hibernate (as 
the the service API's do this) I would certainly include my POJO's in 
the API package if starting a new project - but I don't think I always 
did this.

It also means all external tools wanting to use Samigo functionality 
(well this part at least) only have to have 1 samigo dependency)

D

On 03/14/2012 08:25 PM, Karen Tsao wrote:
> Hi David,
>
> One quick question, is it common to have the hibernate POJO's in the 
> api package?
>
> Thanks,
> Karen
>
> On Wed, Mar 14, 2012 at 5:02 AM, David Horwitz 
> <david.horwitz at uct.ac.za <mailto:david.horwitz at uct.ac.za>> wrote:
>
>     Thanks all
>
>     I have merged and committed the fix.
>
>
>     D
>
>
>     On 03/13/2012 11:48 PM, Karen Tsao wrote:
>>     Hi David,
>>
>>     Thanks a lot for your work. I have no objection to commit to trunk.
>>
>>     Thanks,
>>     Karen
>>
>>     On Tue, Mar 13, 2012 at 8:49 AM, Sam Ottenhoff
>>     <ottenhoff at longsight.com <mailto:ottenhoff at longsight.com>> wrote:
>>
>>         I have tested your branch code against the latest trunk and
>>         have not run into any problems.
>>
>>         I tested creating an assessment, modifying settings,
>>         publishing, taking the assessment as a student, viewing
>>         statistics as a student, view scores as an instructor.  All
>>         tests worked as expected.
>>
>>         Thanks for your work.  +1
>>
>>         Sam
>>
>>
>>         On Tue, Mar 13, 2012 at 4:44 AM, David Horwitz
>>         <david.horwitz at uct.ac.za <mailto:david.horwitz at uct.ac.za>> wrote:
>>
>>             Hi All,
>>
>>             Just wanted to check, any objection if I commit SAM-1615
>>             to trunk?
>>
>>             Regards
>>
>>             David
>>
>>             _______________________________________________
>>             samigo-team mailing list
>>             samigo-team at collab.sakaiproject.org
>>             <mailto:samigo-team at collab.sakaiproject.org>
>>             http://collab.sakaiproject.org/mailman/listinfo/samigo-team
>>
>>
>>
>>         _______________________________________________
>>         samigo-team mailing list
>>         samigo-team at collab.sakaiproject.org
>>         <mailto:samigo-team at collab.sakaiproject.org>
>>         http://collab.sakaiproject.org/mailman/listinfo/samigo-team
>>
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://collab.sakaiproject.org/pipermail/samigo-team/attachments/20120314/c0f6f069/attachment.html