[sakai-pmc] Help on SAM-1943

[Matthew Jones]

I agree, it looks like it's a combination of

- some static code review updates like

-        floats.add(Double.valueOf(autoScore + overrideScore));
+        doubles.add(Double.valueOf(autoScore + overrideScore))

-    updateItemXml(itemXml, xPath, "" + score.toString());
+    updateItemXml(itemXml, xPath, score.toString())

- some long standing updates that are nice to have cleanups for Samigo
(like updating randomly placed integers throughout the code to use the
TypeIfc class constants)
- update to unit tests
- some useless comments, unused code that wasn't cleaned up, and end of
line (CRLF) changes

- and finally the patch for EMI question type

all mixed up together in one huge patch that someone will manually have to
go through and create a few jiras out of.

If this was in an msub (or even another public version control) somewhere
it would *probably* be easier to have just pulled out each commit
individually rather than the complete diff.



On Mon, Feb 10, 2014 at 10:20 AM, Sam Ottenhoff <ottenhoff at longsight.com>wrote:

> >   What does checkMembershipForGroupRelease() and
> isUserInAuthorizedGroup() have to do with adding a new question type?
>
> Absolutely nothing.  It's a gigantic patch that includes hundreds of
> comment changes and lots of code cleanup.  In reality, it looks like it
> should probably be split up into many JIRAs addressing all of the potential
> changes incorporated by the mega patch.  I've left my comments in the code
> review.  Jacques replied that he can't make the patch smaller:
>
>   https://crucible.sakaiproject.org/cru/SAKTRUNK-37
>
>
>
> _______________________________________________
> sakai-pmc mailing list
> sakai-pmc at collab.sakaiproject.org
> http://collab.sakaiproject.org/mailman/listinfo/sakai-pmc
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://collab.sakaiproject.org/pipermail/sakai-pmc/attachments/20140210/c58f16a0/attachment.html