[sakai-pmc] Help on SAM-1943

[Mark J. Norton]

This doesn't really clarify things for me.  What does 
checkMembershipForGroupRelease() and isUserInAuthorizedGroup() have to 
do with adding a new question type?  This was kinda the point I was 
making - do 100 modified files really have to do with a new question 
type?  Your example suggests otherwise.

- Mark

On 2/10/2014 8:31 AM, Sam Ottenhoff wrote:
> A whole lot of the patch is changing comments.  Example: 
> https://crucible.sakaiproject.org/cru/SAKTRUNK-37#CFR-793
>
>
> On Mon, Feb 10, 2014 at 8:28 AM, Mark J. Norton 
> <markjnorton at earthlink.net <mailto:markjnorton at earthlink.net>> wrote:
>
>     Out of curiosity, why would a new question type in Samigo touch over a
>     100 files in Sakai?  This really sounds like a design problem to me,
>     though perhaps I'm being naive.
>
>     - Mark Norton
>
>     On 2/10/2014 8:11 AM, Neal Caidin wrote:
>     > [PMC and Sakai release team]
>     >
>     > Hi,
>     >
>     > This is probably more a Sakai release team question but maybe
>     the PMC
>     > has some guidance here would be appropriate.
>     >
>     > This is a new question type for Samigo, Extended Matching Item,
>     which
>     > has been in production for about a year at UCT in Sakai 2.9 .
>     >
>     > https://jira.sakaiproject.org/browse/SAM-1943
>     > https://crucible.sakaiproject.org/cru/SAKTRUNK-37
>     >
>     > It is a large patch touching many files (upwards of 100 or so).
>     Lydia
>     > and Karen say that the patch does not have too many conflicts
>     and they
>     > would be willing to merge into trunk/Sakai 10. They point out
>     that we
>     > would need to have the patch tested, as well as make sure there
>     are no
>     > regressions in other parts of Sakai. My sense is that probably
>     we will
>     > need to do a full regression on Sakai 10 including Test and
>     Quizzes as
>     > well as other areas. I hope we will be able to bump up the QA
>     testing
>     > effort after we cut the branch, because we had good participation up
>     > till now, but we need a lot more to have confidence in the release.
>     >
>     > What do you think? Is this okay to get into Sakai 10 or for a later
>     > release (either 10.x or Sakai 11)? It might make sense to go
>     ahead an
>     > add it now, if it seems like a good patch, since the issue of the
>     > patch's size and the need for QA does not go away for a future
>     release.
>     > 2 cents.
>     >
>     > Thanks,
>     > Neal
>     >
>     >
>     >
>
>     _______________________________________________
>     sakai-pmc mailing list
>     sakai-pmc at collab.sakaiproject.org
>     <mailto:sakai-pmc at collab.sakaiproject.org>
>     http://collab.sakaiproject.org/mailman/listinfo/sakai-pmc
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://collab.sakaiproject.org/pipermail/sakai-pmc/attachments/20140210/be8e1fb2/attachment.html