[Building Sakai] merging own PRs

[Matthew Jones]

Yeah, this has typically been my practice unless it's a completely obvious
bug fix that I just want a way for someone else to verify.

Like there was on PR I had out from last week, and when researching it more
yesterday found it wasn't even really needed. I believe that there are
still *problems* out there related to this, so the logic is good, but the
specific fix ended up not being useful.

There is a little work if you wait *too* long though, and if you have QA on
staff (like we do at Longsight) it's easier to get it into trunk to have
them look at it on nightly so it can be revised. But I mostly agree with at
least giving most issues a few days.

On Tue, Mar 3, 2015 at 6:31 AM, Steve Swinsburg <steve.swinsburg at gmail.com>
wrote:

> After reviewing a bunch of PRs for sakai core, I'm tending to think that
> we shouldn't be merging our own PRs unless a day or two has elapsed to
> allow people thechance to review.
>
> Git allows us to pull from other branches pretty easily so you should
> never be blocked on waiting for a PR, just merge it into the next branch
> and continue on, meaning there really isn't a reason to be instantly
> merging your own PR.
>
> What are other peoples thought on this? I think it would encourage a lot
> more collaboration.
>
> cheers,
> Steve
>
> _______________________________________________
> sakai-dev mailing list
> sakai-dev at collab.sakaiproject.org
> http://collab.sakaiproject.org/mailman/listinfo/sakai-dev
>
> TO UNSUBSCRIBE: send email to
> sakai-dev-unsubscribe at collab.sakaiproject.org with a subject of
> "unsubscribe"
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://collab.sakaiproject.org/pipermail/sakai-dev/attachments/20150303/0ebc6bf0/attachment.html