[Building Sakai] merging own PRs

[Adrian Fish]

+1

It doesn't mean we're enforcing a peer review process, we're just giving
people who are online a chance to make suggestions. It is tempting just to
merge and carry on as it feels like a reduction in cognitive load, but I
think a short period is appropriate.

On 3 March 2015 at 11:31, Steve Swinsburg <steve.swinsburg at gmail.com> wrote:

> After reviewing a bunch of PRs for sakai core, I'm tending to think that
> we shouldn't be merging our own PRs unless a day or two has elapsed to
> allow people thechance to review.
>
> Git allows us to pull from other branches pretty easily so you should
> never be blocked on waiting for a PR, just merge it into the next branch
> and continue on, meaning there really isn't a reason to be instantly
> merging your own PR.
>
> What are other peoples thought on this? I think it would encourage a lot
> more collaboration.
>
> cheers,
> Steve
>
> _______________________________________________
> sakai-dev mailing list
> sakai-dev at collab.sakaiproject.org
> http://collab.sakaiproject.org/mailman/listinfo/sakai-dev
>
> TO UNSUBSCRIBE: send email to
> sakai-dev-unsubscribe at collab.sakaiproject.org with a subject of
> "unsubscribe"
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://collab.sakaiproject.org/pipermail/sakai-dev/attachments/20150303/0494b6e9/attachment.html