[Building Sakai] What's your strategy for reviewing PRs?

Steve Swinsburg steve.swinsburg at gmail.com
Mon Mar 2 04:06:49 PST 2015


Hi all,

Just wondering what your strategy is for reviewing PRs? If its more than a
simple change I like to checkout and run it up to see it working, however I
find this very difficult with github PRs and remote forks as I need to
clone that user's repo in order to get the remote branch (or do I?) and
that typically takes an hour or more.

What would be neat is if github could just give me a patch that I can apply
to my own fork, which I could then just reset.

The scenario I am working from is this PR which I would like to review:
https://github.com/sakaiproject/sakai/pull/205/files

cheers,
Steve
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://collab.sakaiproject.org/pipermail/sakai-dev/attachments/20150302/af15b501/attachment.html 


More information about the sakai-dev mailing list