[Building Sakai] FCKEditor   vs CKEditor

[Matthew Jones]

Yea you're right, in AssignmentAction it does:
                        // the instructor comment
                        String feedbackCommentString =
StringUtils.trimToNull((String)
state.getAttribute(GRADE_SUBMISSION_FEEDBACK_COMMENT));
                        if (feedbackCommentString != null)
                        {

sEdit.setFeedbackComment(feedbackCommentString);
                        }

So maybe if it's null it needs to set an empty string instead of just
skipping it. I'm not sure how to get that behavior back for CKEditor. It
sounds like it was a bug in the first place in FCKEditor. I don't see any
jira about this yet.


On Fri, May 10, 2013 at 9:10 AM, Kusnetz, Jeremy <JKusnetz at apus.edu> wrote:

>  I created JIRA SAK-23591.  We found that when using the CKEditor in the
> Assignments tool that if an instructor leaves feedback and then decides to
> remove the feedback by clearing out the text and saving that the comments
> do not get removed.  Using the FCKEditor this does not happen.  Looking
> closer the FCKEditor always starts off with a &nbsp; inside the text
> field.  When the instructor clears out their text there is still the &nbsp;
> left in the source.  With the CKEditor the text field is completely empty.
> ****
>
> ** **
>
> I think the bug with the Assignments tool is a NULL comment won’t override
> what’s in the database.  But that leads to a possibly bigger issue.  If the
> default behavior of the CKEditor vs the FCKEditor is different, what other
> tools may be affected in the same way?****
>
> ** **
>
> I’ve tried setting config.fillEmptyBlocks = true in config.js but that
> doesn’t seem to restore having a default &nbsp;****
>
> ** **
>
> Any thoughts on dealing with the difference between the two editors?****
>
> ** **
>
> ** **
>
> This message is private and confidential. If you have received it in
> error, please notify the sender and remove it from your system.
>
> _______________________________________________
> sakai-dev mailing list
> sakai-dev at collab.sakaiproject.org
> http://collab.sakaiproject.org/mailman/listinfo/sakai-dev
>
> TO UNSUBSCRIBE: send email to
> sakai-dev-unsubscribe at collab.sakaiproject.org with a subject of
> "unsubscribe"
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://collab.sakaiproject.org/pipermail/sakai-dev/attachments/20130510/20b73664/attachment.html