[Building Sakai] Portal NEO Prefix

[Adams, David]

I agree 100% with Steve here.

Breaking the longstanding behavior of a property is a bug. I'm not worried about the tools here, but even if all the tools worked correctly, the way this setting works currently is confusing and already causing problems as deployers who didn't write the portal code don't know which skin directory to update. So long as this remains this will continue to crop up as a problem.

I'm sure there are ways to keep the tools broken without confusing users if that is the goal.

-dave



On Mar 17, 2013, at 6:57 PM, "Steve Swinsburg" <steve.swinsburg at gmail.com<mailto:steve.swinsburg at gmail.com>> wrote:

Putting aside the 'tools are wrong argument' (which I agree with, see below.) I still don't see a need for the automatic prefixing of skins in the the portal code.

It seems this code is catering for the sites that may have properties for their own skins defined, which can easily be taken care of at either upgrade time or at any time afterwards, with a line of SQL to upgrade them.

Re tools: Note that the Wicket way of rendering CSS has been around since 2.5 and worked since then. I'm not saying its the right way, and I'll look at changing tools so its done via that request attribute, but its worked for a long time. I am sure that its not only Wicket tools that manually include the skin css though. Also the requirement to inline the body onload will probably conflict with tools that use a jQuery document ready.

cheers,
Steve



On Mon, Mar 18, 2013 at 5:25 AM, David Adams <da1 at vt.edu<mailto:da1 at vt.edu>> wrote:
> These Archetypes were built when folks were not looking too closely -
> we had no chief architect

Do we have a chief architect now?
_______________________________________________
sakai-dev mailing list
sakai-dev at collab.sakaiproject.org<mailto:sakai-dev at collab.sakaiproject.org>
http://collab.sakaiproject.org/mailman/listinfo/sakai-dev

TO UNSUBSCRIBE: send email to sakai-dev-unsubscribe at collab.sakaiproject.org<mailto:sakai-dev-unsubscribe at collab.sakaiproject.org> with a subject of "unsubscribe"