[Building Sakai] problem with gradebook
Neal Caidin
nealcaidin at sakaifoundation.org
Thu Jun 20 04:43:43 PDT 2013
Has a Jira been opened for this one yet?
We might want to discuss on today's CLE release team call.
Thanks,
Neal Caidin
CLE Community Coordinator
On Wed, Jun 19, 2013 at 4:14 PM, Charles Hedrick <hedrick at rutgers.edu>wrote:
>
> On Jun 19, 2013, at 3:04 PM, Matthew Jones <matthew at longsight.com> wrote:
>
> What do you think the one line fix to gradebook is?
>
>
> The code is in ViewByStudentBean.java
>
> if (isInstructorView) {
> } else {
> externalAssignments =
> gext.getExternalAssignmentsForCurrentUser(gradebook.getUid());
> }
>
> while (i.hasNext()) {
> Assignment assignment =
> ((AssignmentGradeRow)i.next()).getAssociatedAssignment();
>
> if (assignment.isExternallyMaintained() &&
> !externalAssignments.containsKey(assignment.getExternalId())) {
> i.remove();
> }
> }
>
>
> The one-line version would be to remove the i.remove(). But it would make
> sense to remove all of that.
>
>
> _______________________________________________
> sakai-dev mailing list
> sakai-dev at collab.sakaiproject.org
> http://collab.sakaiproject.org/mailman/listinfo/sakai-dev
>
> TO UNSUBSCRIBE: send email to
> sakai-dev-unsubscribe at collab.sakaiproject.org with a subject of
> "unsubscribe"
>
--
Neal Caidin
Sakai CLE Community Coordinator
nealcaidin at sakaifoundation.org
skype: nealkdin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://collab.sakaiproject.org/pipermail/sakai-dev/attachments/20130620/353f3dff/attachment.html
More information about the sakai-dev
mailing list