[Building Sakai] problem with gradebook

[Charles Hedrick]

Yes. But the gradebook code does getAllExternalAssignments, and refuses to show any assignments that aren't returned by the API.

There's a potential issue, in that the API is the only way to tell whether an assignment is by group. However the obvious thing is to assume if the API doesn't know about it that it can't be grouped.

The code is in ViewByStudentBean.java 

                if (isInstructorView) {
                } else {
                        externalAssignments = gext.getExternalAssignmentsForCurrentUser(gradebook.getUid());
                }

                while (i.hasNext()) {
                        Assignment assignment = ((AssignmentGradeRow)i.next()).getAssociatedAssignment();

                        if (assignment.isExternallyMaintained() && !externalAssignments.containsKey(assignment.getExternalId())) {
                                i.remove();
                        }
                }

I can implement that API in Lessons, although there's a problem in copying sites that will make items from sites that were copied not show up. I'll obviously fix it so sites that are newly copied will be OK.

But this means that 2.9.1 and 2.9.2 sites will need to update to the newest Lessons if they use grading.

I think this is a problem with no really good solution.


On Jun 19, 2013, at 3:00 PM, Bryan Holladay <holladay at longsight.com> wrote:

> Hmmm.. you're right, I also think it only added API's... Is this what you are referring to Chuck?
> 
> 
> On Wed, Jun 19, 2013 at 2:44 PM, Aaron Zeckoski <azeckoski at unicon.net> wrote:
> Didn't that only add methods to the API? If I am wrong on that can
> someone point out where the change was.
> If I am right, how does that break anything?
> -AZ
> 
> 
> On Wed, Jun 19, 2013 at 2:32 PM, Bryan Holladay <holladay at longsight.com> wrote:
> > https://jira.sakaiproject.org/browse/SAK-22978
> >
> >
> > On Wed, Jun 19, 2013 at 2:28 PM, Aaron Zeckoski <azeckoski at unicon.net>
> > wrote:
> >>
> >> What's the change?
> >> -AZ
> >>
> >>
> >> On Wed, Jun 19, 2013 at 1:55 PM, Charles Hedrick <hedrick at rutgers.edu>
> >> wrote:
> >> > There has a been an API change from 2.9.0 to 2.9.1. Tools that do not
> >> > know about this change will not have grades visible to students.
> >> >
> >> > That means that grades supplied by Lessons, Mneme, and some grades
> >> > supplied by Samigo are not visible to the students.
> >> >
> >> > This is a hard problem because it means that both 2.9.1 and 2.9.2 are
> >> > broken. I can fix lessons to implement the new API, though this could
> >> > require some real hackery to let me build on 2.8 and 2.9.1. I'd prefer a
> >> > one-line fix to gradebook so that it still shows grades even if the tool
> >> > doesn't support the new API. Gradebook 2 does not have this problem.
> >> >
> >> > Any thoughts? Nothing we do will fix 2.9.1 or 2.9.2.
> >> >
> >> > In Lessons the issue shows with grading comments and student content.
> >> >
> >> > We are about to move from 2.9.0 to 2.9.1. In test sites based on a copy
> >> > of the production database, a bunch of existing grades disappear in 2.9.1.
> >> > We consider this a blocker. Unfortunately it's a block for 2.9.1 and 2.9.2.
> >> >
> >> >
> >> >
> >> > _______________________________________________
> >> > sakai-dev mailing list
> >> > sakai-dev at collab.sakaiproject.org
> >> > http://collab.sakaiproject.org/mailman/listinfo/sakai-dev
> >> >
> >> > TO UNSUBSCRIBE: send email to
> >> > sakai-dev-unsubscribe at collab.sakaiproject.org with a subject of
> >> > "unsubscribe"
> >>
> >>
> >>
> >> --
> >> Aaron Zeckoski - Software Architect - http://tinyurl.com/azprofile
> >> _______________________________________________
> >> sakai-dev mailing list
> >> sakai-dev at collab.sakaiproject.org
> >> http://collab.sakaiproject.org/mailman/listinfo/sakai-dev
> >>
> >> TO UNSUBSCRIBE: send email to
> >> sakai-dev-unsubscribe at collab.sakaiproject.org with a subject of
> >> "unsubscribe"
> >
> >
> 
> 
> 
> --
> Aaron Zeckoski - Software Architect - http://tinyurl.com/azprofile
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://collab.sakaiproject.org/pipermail/sakai-dev/attachments/20130619/f76edace/attachment.html