[Building Sakai] Remove all support for Frame Sets in the Sakai-10 Portal

Matthew Jones matthew at longsight.com
Sat Dec 21 13:00:43 PST 2013


Sounds good to me, too most bad places don't consider negative LOC to be a
good metric. I also think code reduction and cleanup is great!


On Sat, Dec 21, 2013 at 3:58 PM, Steve Swinsburg
<steve.swinsburg at gmail.com>wrote:

> Assuming no impact to any other bits of the portal or tools, then +1.
>
> cheers,
> Steve
>
>
> On Sun, Dec 22, 2013 at 2:44 AM, Charles Severance <csev at umich.edu> wrote:
>
>> From https://jira.sakaiproject.org/browse/SAK-25492
>>
>> Long ago, I added the concept of an alternate view of the Sakai portal
>> markup that put the top navigation and bottom page space into two frames in
>> a frame set (yes frame sets from 1994). I did this because it would have
>> eliminated the scrolling and need to resize the content frames at the cost
>> of frameset ugliness.
>>
>> https://source.sakaiproject.org/viewsvn?view=revision&revision=40417
>>
>> This was a bad idea from the beginning and I think not used anywhere. And
>> it has not been tested to my knowledge since I tested it in 2008 when I
>> wrote it.
>>
>> So I am going to scrub the code of this feature for Sakai-10.   I love
>> deleting code :)
>>
>> Comments welcome - but if you have an objection, raise it quickly.
>>
>> /Chuck
>>
>> _______________________________________________
>> sakai-dev mailing list
>> sakai-dev at collab.sakaiproject.org
>> http://collab.sakaiproject.org/mailman/listinfo/sakai-dev
>>
>> TO UNSUBSCRIBE: send email to
>> sakai-dev-unsubscribe at collab.sakaiproject.org with a subject of
>> "unsubscribe"
>>
>
>
> _______________________________________________
> sakai-dev mailing list
> sakai-dev at collab.sakaiproject.org
> http://collab.sakaiproject.org/mailman/listinfo/sakai-dev
>
> TO UNSUBSCRIBE: send email to
> sakai-dev-unsubscribe at collab.sakaiproject.org with a subject of
> "unsubscribe"
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://collab.sakaiproject.org/pipermail/sakai-dev/attachments/20131221/30c15268/attachment.html 


More information about the sakai-dev mailing list