[Building Sakai] Too many copies of log4j.jar ??

Aaron Zeckoski azeckoski at unicon.net
Mon Sep 10 14:18:38 PDT 2012


In general one does not want to see multiple copies of a logging
implementation. At most, you might have multiple copies of your
logging abstraction (slf4j or JCL) but even that is problematic
(especially for JCL). I would say that we probably want all of these
switched over to only include log4j for testing (especially since no
one should be using log4j directly). That's probably what they meant
to do anyway (I would guess).

-AZ


On Mon, Sep 10, 2012 at 5:04 PM, Charles Severance <csev at umich.edu> wrote:
>
> On Sep 10, 2012, at 12:14 PM, Seth Theriault wrote:
>
>> On Mon, Sep 10, 2012 at 11:49 AM, Charles Severance <csev at umich.edu> wrote:
>>> I am playing with the 2-9-x branch and there are too many log4j jar files:
>>>
>>> ./common/lib/log4j-1.2.16.jar
>>> ./components/profile2-pack/WEB-INF/lib/log4j-1.2.14.jar
>>> ./webapps/accountvalidator/WEB-INF/lib/log4j-1.2.14.jar
>>> ./webapps/mailsender-tool/WEB-INF/lib/log4j-1.2.14.jar
>>> ./webapps/profile2-tool/WEB-INF/lib/log4j-1.2.14.jar
>>> ./webapps/sakai-gradebook-tool/WEB-INF/lib/log4j-1.2.14.jar
>>> ./webapps/sakai-reset-pass/WEB-INF/lib/log4j-1.2.14.jar
>>> ./webapps/sakai-site-manage-group-section-role-helper/WEB-INF/lib/log4j-1.2.14.jar
>>
>> Many of these tools have "indie" status or are separately maintained.
>> It is very possible that are not up to date (this is a somewhat
>> frequent occurrence).
>
> But these tools should just assume that log4j is in shared and make the tiny change to their pom.
>
> Or is there a valid reason to put the jar in warts here and there.
>
> Seems like a little nice thing to clean up.
>
> /Chuck
>
> _______________________________________________
> sakai-dev mailing list
> sakai-dev at collab.sakaiproject.org
> http://collab.sakaiproject.org/mailman/listinfo/sakai-dev
>
> TO UNSUBSCRIBE: send email to sakai-dev-unsubscribe at collab.sakaiproject.org with a subject of "unsubscribe"



-- 
Aaron Zeckoski - Software Architect - http://tinyurl.com/azprofile


More information about the sakai-dev mailing list