[Building Sakai] LB 1.3.x question about r98589 – don't show group list if empty

Charles Hedrick hedrick at rutgers.edu
Wed Oct 12 07:36:53 PDT 2011


Yes. A group with no members should still be shown. The patch was intended to fix a problem where the "show groups" link was there even though there were no groups. It seems silly to give the user an option that doesn't do anything useful.

On Oct 11, 2011, at 4:54 PM, Walters, Cynthia (cmw6s) wrote:

> Hi Charles:
> I also took a look at the code changed for this revision (r98589 -- don't show group list if empty) and this is working as follows, which I think is the correct behavior:
> 
> If there are zero groups defined, the LB page does not display a link to the group list.
> 
> So I think our first thought about this was incorrect.
> 
> Thanks, 
> Cindy
> 
> 
> From: sakai-dev-bounces at collab.sakaiproject.org [sakai-dev-bounces at collab.sakaiproject.org] on behalf of Walters, Cynthia (cmw6s) [cmw6s at eservices.virginia.edu]
> Sent: Monday, October 10, 2011 1:05 PM
> To: sakai-dev at collab.sakaiproject.org
> Subject: [Building Sakai] LB 1.3.x question about r98589 – don't show group list if empty
> 
> Hi:
> 
> We want to verify we are testing correctly for adding this fix to our code base (Lesson Builder 1.3.x for Sakai 2.7.1).
> 
> Can you describe the use-case or unit test, or point me to a JIRA if that applies.
> 
> We first thought this may mean that a group with zero members will not be shown in the list to choose a group from, but perhaps it means the link to a group list is not shown if there are zero groups defined?
> 
> Thanks very much,
> Cynthia Gast Walters @ UVa
> 
> 
> _______________________________________________
> sakai-dev mailing list
> sakai-dev at collab.sakaiproject.org
> http://collab.sakaiproject.org/mailman/listinfo/sakai-dev
> 
> TO UNSUBSCRIBE: send email to sakai-dev-unsubscribe at collab.sakaiproject.org with a subject of "unsubscribe"

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://collab.sakaiproject.org/pipermail/sakai-dev/attachments/20111012/4971e810/attachment.html 


More information about the sakai-dev mailing list