[Building Sakai] KNL-273 & LSNBLDR-18

[Bryan Holladay]

Sam said he thinks the edge case you brought up was a small zip file
with millions of files being expanded.  I've added a property to
prevent this: resources.zip.expand.max=1000  (defaulted at 1000)

Thanks,
Bryan

On Tue, Oct 4, 2011 at 2:13 PM, Matthew Jones <jonespm at umich.edu> wrote:
> Hi Bryan,
> Sorry I'd forgotten about this. I remember talking to Sam at the conference
> and being positive about these fixes. I had one more addition for a possible
> edge case which should be resolved prior to 2.9 release if this was included
> which I can document. I agree that it is useful functionality and both
> functions should just use the same library. As long as it's committed early
> there's no plans to backport another api/interface breaking change back to
> past releases (ugh, SAK-18838) I'm good with it. Java with it's default
> interface/implementation makes this too easy to break. Dunno how anyone else
> feels though about adding it.
> -Matthew
>
> On Tue, Oct 4, 2011 at 12:19 PM, Bryan Holladay <holladay at longsight.com>
> wrote:
>>
>> Could we get a final vote on KNL-273.  It has been pending for almost
>> a year now and several institutions have requested this feature.  It's
>> off by default and there have been measures put in place to prevent
>> the risk of DOS (as requested).  It was last mentioned in the thread
>>
>> http://collab.sakaiproject.org/pipermail/sakai-dev/2011-September/014100.html
>> when Lesson Builder added the same functionality to it's trunk code in
>> LSNBLDR-18.
>>
>> If it passes, then KNL-273 will need to be added trunk (after the
>> freeze).  If it doesn't, then LSNBLDR-18 will need to be reverted
>> since it's the same functionality (especially if LB will be cut for
>> Sakai 2.9).
>>
>> I would start the vote, but I don't think I'm allowed to vote on my own
>> jira.
>>
>> Thanks,
>> Bryan
>> _______________________________________________
>> sakai-dev mailing list
>> sakai-dev at collab.sakaiproject.org
>> http://collab.sakaiproject.org/mailman/listinfo/sakai-dev
>>
>> TO UNSUBSCRIBE: send email to
>> sakai-dev-unsubscribe at collab.sakaiproject.org with a subject of
>> "unsubscribe"
>
>