[Building Sakai] Unrolled students are receiving assignment notifications

[DAVID ROLDAN MARTINEZ]

Hi Jim,

Thank you very much for you answer.

How about to be able to configure this in sakai.properties? In this case, the modification should be done at BaseAssignmentService notification events, shouldn't it?

Cheers,
                DRM

De: Jim Eng [mailto:jimeng at umich.edu]
Enviado el: miércoles, 26 de enero de 2011 14:13
Para: DAVID ROLDAN MARTINEZ
CC: sakai-dev at collab.sakaiproject.org
Asunto: Re: [Building Sakai] Unrolled students are receiving assignment notifications

I'm not sure this is a bug, though I think that is not entirely clear.  It seems to me that notifications should go to all students who submitted an assignment even if they later disenroll. Students are often interested in how they did on an assignment or test, even if it no longer affects a grade.

Jim


On Jan 26, 2011, at 8:04 AM, DAVID ROLDAN MARTINEZ wrote:


                Hi all,

                We have experiencing a curious issue: enrolled students are receiving assignment notifications. We're running 2.6.x but I've checked the code and it's the same at trunk so, probably, this bug will affect also to trunk. :(
                To reproduce the problem, please, follow these steps (https://jira.sakaiproject.org/browse/SAK-19916):
1.       Add some students to a site (Site A)
2.       Add a new assignment (Asn A)
3.       Go to "view submissions" or "grade" but don't do any action and go back to assignment list.
4.       Remove one student from Site A (student A).
5.       Grade Asn A and realase grades by clicking the link.
6.       Student A will receive the notification. This is a bug because Student A has been unrolled and thus, she/he is not a site member.

This is because at point 3, a row per enrolled user is created at ASSIGNMENT_SUBMISSION table. Then when AssigmentSubmission.getSubmitters() is invoked, rows from enrolled both unrolled students are returned.  To avoid this, we must filter AssigmentSubmission.getSubmitters() to check if user still have access to the site before to send notifications. This filtering process can be done at AssigmentSubmission  or BaseAssignmentService notification methods (sendGradeReleaseNotification, notificationToInstructorsa and notificationToStudents). From my point of view, it must be done at AssignmentSubmission. What do you think?

Thank you very much in advance.

Cheers,
                DRM
_______________________________________________
sakai-dev mailing list
sakai-dev at collab.sakaiproject.org<mailto:sakai-dev at collab.sakaiproject.org>
http://collab.sakaiproject.org/mailman/listinfo/sakai-dev

TO UNSUBSCRIBE: send email to sakai-dev-unsubscribe at collab.sakaiproject.org<mailto:sakai-dev-unsubscribe at collab.sakaiproject.org> with a subject of "unsubscribe"

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://collab.sakaiproject.org/pipermail/sakai-dev/attachments/20110126/52429d4e/attachment.html