[Building Sakai] Unrolled students are receiving assignment notifications

[DAVID ROLDAN MARTINEZ]

                Hi all,

                We have experiencing a curious issue: enrolled students are receiving assignment notifications. We're running 2.6.x but I've checked the code and it's the same at trunk so, probably, this bug will affect also to trunk. :(
                To reproduce the problem, please, follow these steps (https://jira.sakaiproject.org/browse/SAK-19916):

1.       Add some students to a site (Site A)

2.       Add a new assignment (Asn A)

3.       Go to "view submissions" or "grade" but don't do any action and go back to assignment list.

4.       Remove one student from Site A (student A).

5.       Grade Asn A and realase grades by clicking the link.

6.       Student A will receive the notification. This is a bug because Student A has been unrolled and thus, she/he is not a site member.

This is because at point 3, a row per enrolled user is created at ASSIGNMENT_SUBMISSION table. Then when AssigmentSubmission.getSubmitters() is invoked, rows from enrolled both unrolled students are returned.  To avoid this, we must filter AssigmentSubmission.getSubmitters() to check if user still have access to the site before to send notifications. This filtering process can be done at AssigmentSubmission  or BaseAssignmentService notification methods (sendGradeReleaseNotification, notificationToInstructorsa and notificationToStudents). From my point of view, it must be done at AssignmentSubmission. What do you think?

Thank you very much in advance.

Cheers,
                DRM
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://collab.sakaiproject.org/pipermail/sakai-dev/attachments/20110126/c9425c26/attachment.html