[Building Sakai] rWiki bug and patch

[Jon Wheat]

for real ?  ... sorry, I missed that somehow. 

>Fix Version 2.7.0, 2.8.0-b01 

ok, so I have 2.7.1 revision 86841 ... so would that fix not have made it to 2.7.1 for some reason ? 


>>> "Silverio, Gonzalo" <gsilver at umich.edu> 1/6/2011 10:49 AM >>>
Hi,

Good eye, Jon!

https://jira.sakaiproject.org/browse/SAK-18145

Even if it has been fixed - let me reiterate Noah's thanks, encouragement and invitation to dive in.

-Gonzalo


On Jan 6, 2011, at 10:43 AM, Noah Botimer wrote:

> One more thing...
>
> Thanks and congratulations. Every little bit helps.
>
> If you're feeling punchy, there are plenty of open JIRA tickets. :-)
>
> Thanks,
> -Noah
>
> On Jan 6, 2011, at 10:40 AM, Noah Botimer wrote:
>
>> I should have also mentioned...
>>
>> It's helpful to know your version of Sakai (branch, revision) in these cases. Also, it's usually easiest if you create the patch from the root of the tool's module or your source tree. And, if you've got, for example, a 2.7.x working copy, an svn diff will include revision information automatically in the patch.
>>
>> That is, a convenient patch would be created by issuing a plain "svn diff" in your [src]/rwiki directory. Then the merging developer doesn't have to navigate a lot of extra directories.
>>
>> Thanks,
>> -Noah
>>
>> On Jan 6, 2011, at 10:32 AM, Noah Botimer wrote:
>>
>>> Jon,
>>>
>>> Could you please create a JIRA ticket for this and attach the patch to the ticket? If you're not familiar with that process, I'd be interested in how easy or difficult it seems to you (as a gauge of our participatory barriers).
>>>
>>> Savitha is a committer for rWiki, so she can probably apply this for you.
>>>
>>> Thanks,
>>> -Noah
>>>
>>> On Jan 6, 2011, at 10:27 AM, Jon Wheat wrote:
>>>
>>>> I FINALLY get to contribute back to the list.
>>>>
>>>> A bug was reported to us this morning and I found and created a patch for it (attached)
>>>>
>>>> It appears in rWiki, when you click the Info link -
>>>>
>>>> With Firefox and Safari - I have the correct layout for the table - with 5 columns and 5 column headers.
>>>> With Chrome and IE - I have 4 column headers (Read is actually outside the table above the first column) and 5 columns of data, which then do not correspond with the column headers.
>>>>
>>>> I looked at the source and  there's a missing > after the <th   in the Create line below -
>>>>
>>>> <th scope="col"><a href="#" class="rwiki_help_popup_link" name="createhelp" title="Click to view information ">Create</a></th
>>>> Attached is the patch.
>>>> You can go into [src]/rwiki/rwiki-tool/tool/src/webapp/WEB-INF/vm and run patch < rwiki.info.patch
>>>>
>>>> I'll look into posting this to Jira - never done that before though.
>>>> Here's hoping it isn't already there and I didn't see it.
>>>>
>>>> -Jon
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>>> ..:: I've learned that 'impossible' is a perception based on your skills.
>>>> Jonathan Wheat /  Developer
>>>> Luminis Developers Network
>>>> Messiah College, ITS
>>>> 717.766.2511 x3385
>>>> LDN - Luminis Developer Network - http://www.lumdev.net
>>>> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>>>
>>>>
>>>>
>>>> <rwiki.info.patch>_______________________________________________
>>>> sakai-dev mailing list
>>>> sakai-dev at collab.sakaiproject.org
>>>> http://collab.sakaiproject.org/mailman/listinfo/sakai-dev
>>>>
>>>> TO UNSUBSCRIBE: send email to sakai-dev-unsubscribe at collab.sakaiproject.org with a subject of "unsubscribe"
>>>
>>> _______________________________________________
>>> sakai-dev mailing list
>>> sakai-dev at collab.sakaiproject.org
>>> http://collab.sakaiproject.org/mailman/listinfo/sakai-dev
>>>
>>> TO UNSUBSCRIBE: send email to sakai-dev-unsubscribe at collab.sakaiproject.org with a subject of "unsubscribe"
>>
>> _______________________________________________
>> sakai-dev mailing list
>> sakai-dev at collab.sakaiproject.org
>> http://collab.sakaiproject.org/mailman/listinfo/sakai-dev
>>
>> TO UNSUBSCRIBE: send email to sakai-dev-unsubscribe at collab.sakaiproject.org with a subject of "unsubscribe"
>
> _______________________________________________
> sakai-dev mailing list
> sakai-dev at collab.sakaiproject.org
> http://collab.sakaiproject.org/mailman/listinfo/sakai-dev
>
> TO UNSUBSCRIBE: send email to sakai-dev-unsubscribe at collab.sakaiproject.org with a subject of "unsubscribe"

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://collab.sakaiproject.org/pipermail/sakai-dev/attachments/20110106/3f246836/attachment.html