[Building Sakai] weird bug in assignments: it's showing the

Wed Feb 23 18:01:00 PST 2011

We've confirmed with our people that two windows were not involved. I suspect there's some odd timing problem, e.g. a double click with specific timing, that creates the same result.

There's no reason this code should ever produce student name and contents not in sync. I could see giving info on a different student than the faculty member intended, but not an inconsistent screen. I suspect this is simply a  bug, and thus can be fixed. I'm going to look at it myself. As long as there's a way to duplicate it using two windows I think fixing it should be possible.

On Feb 23, 2011, at 3:43:22 PM, Zhen Qian wrote:

> Hi, Sanghyun:
> 
> This multi-browser problem has been reported as SAK-13789 "Assignments Disclosure of Information -multi tab browsing". The fix there was to provide a warning in the grading page for multi-browser grading: "Important Reminder: Please do not grade assignments with multiple browser windows or tabs. Only grade assignments and navigate the system with one browser window."
> 
> Obviously, this patch couldn't prohibit the "open in new window" behavior if instructor choose to do so. If this is of concern, please submit a new jira.
> 
> Thanks,
> 
> - Zhen
> 
>  
>  
> On Wed, 23 Feb 2011 15:25:00 -0500, "Jeon,Sanghyun Seo" <euksa99 at ufl.edu> wrote:
> 
> I can duplicate the problem successfully as follows:
> 
> 1.       Open two windows separately: Windows X and Y
> 
> 2.       Click “ view Submissions” in Windows X
> 
> 3.       Click “Grade” under Student A in Windows X and type something in Instructor Summary Comments Box
> 
> 4.       Just click “Grade” under Student B in Windows Y
> 
> 5.       Back to Windows X and hit “Next”. You will see the Student A’s content under Student B, which is wrong
> 
>  
> Even though you will open new windows and try it again, the Student A’s content with instructor’s comment is displayed under Student B when you login in as instructor, but the correct content will be presented when you login in as each student.
> 
>  
>  
> Sanghyun
> 
>  
> From: Charles Hedrick [mailto:hedrick at rutgers.edu] 
> Sent: Wednesday, February 23, 2011 2:41 PM
> To: Zhen Qian
> Cc: Jeon,Sanghyun Seo; sakai-dev at collab.sakaiproject.org
> Subject: Re: [Building Sakai] weird bug in assignments: it's showing the
> 
>  
> I wouldn't expect you to be able to duplicate the problem. It occurs randomly in a few small percentage of cases. It's either truly random or depends upon specific timing of events.
> 
>  
> We have seen it i both IE 7 and Firefox, so it's not the browser.
> 
>  
> Here are the database transactions for the second submission, i.e. the one that got the bad data:
> 
> insert lock
> update submission, correct
> delete lock
> sakai event asn.grade.submission
> lock
> update submission, with bad feedback entry
> delete lock
> event asn.grade.submission
> event asn.read.submission
> 
> Interestingly the previous one shows an update and asn.grade.submission without a lock/unlock, possibly because no change was made?
> 
>  
>  
> On Feb 23, 2011, at 2:28 PM, Zhen Qian wrote:
> 
> 
> 
> 
> Chuck:
> 
> We are currently running 2.7.1 with extra patches.
> 
> However, I cannot repeat the problem by following the step below. Could you provide more details here?
> 
> Thanks,
> 
> - Zhen
> 
>  
> On Wed, 23 Feb 2011 14:15:14 -0500, Charles Hedrick <hedrick at rutgers.edu> wrote:
> 
> OK, so it's now happening at at least 3 places. Any commonality in sakai versions? We hadn't seen it under 2.7.0, but are seeing it in 2.7.1.
> 
> Yes, they are inline text, not attachments.
> 
> What's happening is the following:
> 
> instructor hits "next"
> 
> new screen comes up with text from old screen in FCK
> 
> instructor does next or previous
> 
> an automatic save occurs. The contents of FCK are saved as feedback, i.e. Sakai thinks it's a version of the student's assignment with instructor comments
> 
> The database shows the correct submission, but the wrong one as feedback.
> 
> If you go back to the assignment in the UI, you'll see the wrong data, because when feedback exists, the UI will show it rather than the original submission.
> 
> We think other data such as grade may also be duplicated, but we can't be sure yet.
> 
> I don't see how having another window open would have any effect. The instructor is going from one student to another in the same window. I understand that doing that isn't safe, but it wold require a very strange and unlikely pattern of actions in the two windows to cause this effect.
> 
> It's happened enough that I consider it a crisis.
> 
>  
> On Feb 23, 2011, at 12:38 PM, Jeon,Sanghyun Seo wrote:
> 
>  
> Hello,
> 
>  
> We, University of Florid, are having the exact same problem, which happened yesterday.
> 
> That’s for inline assignments, not attachments as well as unlimited submissions.
> 
> The instructor claimed that he knew there was a problem as soon as he opened it, because the student names did not match up.
> 
> He even did not try to give any inline comments or scores due to this error.
> 
> But he admitted that there could have been another browser open.
> 
>  
> My question is that which database table stores student’s view content and which one stores instructor’s view content.
> 
> When I logged in as Student A, Student A’s submission contains “content A”, and Student B’s submission contains “content B”, which are correct.
> 
> However,
> 
> when I logged in as instructor, then Student A had “content A”, which is right, but Student B also has “content A”, which is wrong.
> 
> Since student’s view contents are correct for both case, but instructor’s view contents are different, I would like to start to investigate the db first.
> 
> If you know any related java classes, please let us know that too.
> 
> Thank you in advance.
> 
>  
> Sanghyun
> 
>  
>  
>  
>  

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://collab.sakaiproject.org/pipermail/sakai-dev/attachments/20110223/6db7ac30/attachment.html 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 3817 bytes
Desc: not available
Url : http://collab.sakaiproject.org/pipermail/sakai-dev/attachments/20110223/6db7ac30/attachment.bin 