[Building Sakai] r44689 change in FeedbackOptionsBean.java

[Qu, Yuanhua]

Hi,

The following change forbid user to change grade type to be "Letter Grades"  in Gradebook Options page when grade entry is "Letter Grades";  I would like to know why? Want to make sure I'm not breaking any logic or feature if I take away those 5 lines.

I noticed that this was probably added  to forbig user to change grade scale mapping while they have "Letter Grades" as grade entry .  In Gradebook Options page, I think there are at least two functions, one is just changing grade type and save it without changing the scale mapping;  the other is changing scale mapping.  Noticing the method isConflictWithLetterGrade has already did the job of guarding scale mapping not to be changed while grade entry is "Letter Grades".  So here is my question:

 May I safely take away this changes from FeedbackOptionsBean.java so that instructor can actually change grade type  to be "Letter Grades"  in the Gradebook Options page when grade entry is "Letter Grades"?  If I can safely do that,   instructor will be able to  actually change grade type  to be "Letter Grades"  in the Gradebook Options page when grade entry is "Letter Grades" without actually changing the mapping at all.


(+                    if(localGradebook.getGrade_type() == GradebookService.GRADE_TYPE_LETTER && mapping.getGradingScale().getUid().equals("LetterGradeMapping"))
+                    {
+                        isValidWithLetterGrade = false;
+                        return;
+                    }


Thanks for any help.

-Qu


-- gradebook/trunk/app/ui/src/java/org/sakaiproject/tool/gradebook/ui/FeedbackOptionsBean.java 2008/03/31 14:37:25 44688
+++ gradebook/trunk/app/ui/src/java/org/sakaiproject/tool/gradebook/ui/FeedbackOptionsBean.java 2008/03/31 14:54:56 44689
@@ -158,9 +158,15 @@
   * shown mapping, but we do remember them.
   */
  public void changeGradeType(ActionEvent event) {
+  isValidWithLetterGrade = true;
   for(Iterator iter = localGradebook.getGradeMappings().iterator(); iter.hasNext();) {
             GradeMapping mapping = (GradeMapping)iter.next();
             if(mapping.getId().equals(selectedGradeMappingId)) {
+              if(localGradebook.getGrade_type() == GradebookService.GRADE_TYPE_LETTER && mapping.getGradingScale().getUid().equals("LetterGradeMapping"))
+              {
+               isValidWithLetterGrade = false;
+               return;
+              }
                 localGradebook.setSelectedGradeMapping(mapping);
                 initGradeRows();
             }
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://collab.sakaiproject.org/pipermail/sakai-dev/attachments/20100707/03a917e1/attachment.html