[Building Sakai] K1 - uitils rationalization?

[Adrian Fish]

+1

David, please ignore my hasty response to you personally. I'm not trying 
to vote twice, honest.

David Horwitz wrote:
> Hi All,
>
> I was looking at the utils classes in the K1 kernel and it strikes me
> that we could do with some rationalization in this area to achieve:
>
> 1) Remove duplicated functionality
> 2) Remove custom Sakai code that has the same functionality as standard
> java classes (specifically Apache commons libraries)
>
>
> Some of the ones I noticed:
>
>
> 1) EmptyIterator - present in commons-collections
> 2) Web.escapeJsQuotes & Validator.escapeJsQuoted() - duplicate code, in
> commons-lang StringEscapeUtils, one marked deprecated and buggy (KNL-69)
> 3) Validator.escapeSql in commons-lang StringEscapeUtils
> 4) Validator.esapceJavascript in commons-lang StringEscapeUtils
> 5) Validator.checkEmailLocal in commons-validator
> 6) StringUtils.split - "Like jdk1.4's String.split..." the javadoc says
> it all this is now in the jvm
> 7) StringUtils.trimToNull & StringUtils.trimToEmpty
>
> This is just a quick survey and I'm sure there more. I Propose that we
> start by marking all these as deprecated and point people the the
> commons implementation. Thoughts?
>
>
> David
> _______________________________________________
> sakai-dev mailing list
> sakai-dev at collab.sakaiproject.org
> http://collab.sakaiproject.org/mailman/listinfo/sakai-dev
>
> TO UNSUBSCRIBE: send email to sakai-dev-unsubscribe at collab.sakaiproject.org with a subject of "unsubscribe"
>
>   

-- 
==================================
Adrian Fish
Software Engineer
Centre for e-Science
Bowland Tower South C Floor
Lancaster University
Lancaster
LA1 4YW

email: a.fish at lancaster.ac.uk
web:   http://agora.lancs.ac.uk

-------------- next part --------------
A non-text attachment was scrubbed...
Name: a_fish.vcf
Type: text/x-vcard
Size: 289 bytes
Desc: not available
Url : http://collab.sakaiproject.org/pipermail/sakai-dev/attachments/20090608/59e923e8/attachment.vcf