[sakai-core-team] whitespace changes

[Robert Long]

I am all for changing the formatting, etc. as long as it means spaces and non-hanging braces are the standard... and actually enforced! (This would go along way to curing my code formatting OCD I have...)

Just my 2¢

--Bob

----
Robert Long
Software Engineer
Technical Account Manager - Sakai
Unicon, Inc.

----
M.A., Instructional Technology
Saginaw Valley State University

> On Feb 26, 2015, at 14:58, Sam Ottenhoff <ottenhoff at longsight.com> wrote:
> 
> Ideally, this would have been done during the move from SVN to Git and before lots of people forked sakaiproject/sakai.git.  We should have globally modified all Java code as described in the link below, and then we should have set up a plan to enforce standards via pull request validation.
> 
>   http://stackoverflow.com/questions/4112410/git-change-styling-whitespace-without-changing-ownership-blame <http://stackoverflow.com/questions/4112410/git-change-styling-whitespace-without-changing-ownership-blame>
> 
> The problem with formatting changes is that it's a history killer.  git blame and git diff lose their relevancy.
> 
> How upsetting would it be for all of the Git forks if we rewrote the entire history as described in that StackOverflow post?
> 
> On Mon, Feb 23, 2015 at 12:19 PM, Brian Jones <bjones86 at uwo.ca <mailto:bjones86 at uwo.ca>> wrote:
> Hi Core Team,
> 
> What is the best/accepted process for correcting whitespace
> inconsistencies in file(s) now that we've moved to Github?
> 
> For example, if I'm working through something, and I notice a file has
> mixed tabs vs spaces; it's annoying me and I'd like to just fix it.
> 
> Should I make a PR purely for the whitespace change to keep it separate
> from the feature I'm working on? Do I need to link it to a new Jira that
> is only for the whitespace changes?
> 
> Thanks for your input!
> --
> Brian Jones
> Programmer/Analyst
> Information Technology Services
> Support Services Building, Suite 4300
> Western University
> (519) 661-2111 x86969
> bjones86 at uwo.ca <mailto:bjones86 at uwo.ca>
> _______________________________________________
> sakai-core-team mailing list
> sakai-core-team at collab.sakaiproject.org <mailto:sakai-core-team at collab.sakaiproject.org>
> http://collab.sakaiproject.org/mailman/listinfo/sakai-core-team <http://collab.sakaiproject.org/mailman/listinfo/sakai-core-team>
> 
> _______________________________________________
> sakai-core-team mailing list
> sakai-core-team at collab.sakaiproject.org
> http://collab.sakaiproject.org/mailman/listinfo/sakai-core-team

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://collab.sakaiproject.org/pipermail/sakai-core-team/attachments/20150226/b82d5157/attachment.html