[sakai-core-team] whitespace changes
Kirschner, Beth
bkirschn at umich.edu
Thu Feb 26 13:49:34 PST 2015
I putting formatting changes (such as space/tabs) in a commit & PR all by themselves. So make the formatting changes, test, commit and issue a Pull Request. I don't think you need a separate JIRA, but I wouldn't want to see the formatting changes as part of the PR for your new feature.
- Beth
On Feb 23, 2015, at 12:19 PM, Brian Jones <bjones86 at uwo.ca> wrote:
> Hi Core Team,
>
> What is the best/accepted process for correcting whitespace
> inconsistencies in file(s) now that we've moved to Github?
>
> For example, if I'm working through something, and I notice a file has
> mixed tabs vs spaces; it's annoying me and I'd like to just fix it.
>
> Should I make a PR purely for the whitespace change to keep it separate
> from the feature I'm working on? Do I need to link it to a new Jira that
> is only for the whitespace changes?
>
> Thanks for your input!
> --
> Brian Jones
> Programmer/Analyst
> Information Technology Services
> Support Services Building, Suite 4300
> Western University
> (519) 661-2111 x86969
> bjones86 at uwo.ca
> _______________________________________________
> sakai-core-team mailing list
> sakai-core-team at collab.sakaiproject.org
> http://collab.sakaiproject.org/mailman/listinfo/sakai-core-team
More information about the sakai-core-team
mailing list