[sakai-core-team] Broken and disabled org.sakaiproject.site.impl.test.SiteAliasCleanupNotificationActionTest

Aaron Zeckoski azeckoski at unicon.net
Tue Apr 22 03:43:20 PDT 2014


The count of the number of aliases in the site was non-zero when the
test checked it. It should have been zero.
-AZ

On Tue, Apr 22, 2014 at 5:45 AM, Matthew Buckett
<matthew.buckett at it.ox.ac.uk> wrote:
> The test seems to be working fine for me when building trunk with Java 1.7.0_55
>
> What was the failure you were seeing?
>
> On 11 April 2014 17:24, Aaron Zeckoski <azeckoski at unicon.net> wrote:
>> Part of the updates to the MemoryService seem to have caused
>> org.sakaiproject.site.impl.test.SiteAliasCleanupNotificationActionTest
>> to stop working. This is meant to test that when a site is removed,
>> the associated aliases are also removed.
>> What's confusing about it is that this is a simple event based trigger
>> (SiteService triggers a delete event, then AliasService removes the
>> alias when it hears about the event). It doesn't appear to actually be
>> related to the MemoryService changes and the code which handles this
>> stuff hasn't been touched by anyone in years. I tested the
>> functionality in a running Sakai and it all works so my guess is that
>> the test itself is simply not working right and it was a fluke that it
>> used to work (and likely did not accurately test the scenario).
>> As a result, I have disabled it.
>>
>> If anyone is interested in trying to make that test work then I think
>> it might be nice if we had a working test to verify that functionality
>> but you probably would need to start from scratch.
>>
>> -AZ
>>
>> --
>> Aaron Zeckoski - Software Architect - http://tinyurl.com/azprofile
>> _______________________________________________
>> sakai-core-team mailing list
>> sakai-core-team at collab.sakaiproject.org
>> http://collab.sakaiproject.org/mailman/listinfo/sakai-core-team
>
>
>
> --
>   Matthew Buckett, VLE Developer, IT Services, University of Oxford



-- 
Aaron Zeckoski - Software Architect - http://tinyurl.com/azprofile


More information about the sakai-core-team mailing list