[Portfolio] horrendous code in wizards

Charles Hedrick hedrick at rutgers.edu
Sun Aug 2 14:54:38 PDT 2009

I just fixed some truly horrendous code when filling out wizards.  
Every time you go to a wizard page it fetches every completed wizard  
of that type, for all users, and then checks each one to see if it's  
yours. Because this is done with Hibernate, it pulls all the  
associated data in, including the LDAP data for the owners of all  
those wizards. See http://jira.sakaiproject.org/browse/SAK-15958

http://jira.sakaiproject.org/browse/SAK-13804 dealt with this problem  
by caching, but that's really a band-aid that doesn't fully fix it.

The fix is simple: have the database query select only your own form.  
It's sitting right there in a database field.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 2421 bytes
Desc: not available
Url : http://collab.sakaiproject.org/pipermail/portfolio/attachments/20090802/559bc908/attachment.bin 

More information about the portfolio mailing list