[WG: I18N & L10N] SAK-19758: Job Scheduler internationalization?

[Anthony Whyte]

I am reviewing tickets and code commits as I merge fixes to 2.8.x.  Reviewing SAK-19758, "Job Scheduler Internationalization" I find that a number of *.jsp files had their loadBundle tag (f:loadBundle basename="org.sakaiproject.tool.scheduler.bundle.Messages" var="msgs"/>) excised in favor of loading message bundles via org.sakaiproject.util.ResourceLoader.

No objections to utilizing the ResourceLoader but it seems that this change was made in order to translate the ALT text of a "Powered by Quartz" image resident in a number of *.jsp files.

<h:graphicImage value="/images/quartz.jpg" alt="Powered By Quartz"/>            

to

<h:graphicImage value="/images/quartz.jpg" alt="#{msgs.powered_by} Quartz"/>

Sixteen files were touched to effect this change.  I am not sure how a change like this improves the i18n experience or whether the benefits gained outweigh the costs of implementing and shepherding such a change through our development process.

/ Anthony 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 3829 bytes
Desc: not available
Url : http://collab.sakaiproject.org/pipermail/i18n/attachments/20110107/08eb4c33/attachment.bin