[gradebook2-dev] GRBK-1209

[Thomas Amsler]

This looks good, but I have a couple of questions:

1. For the three added dependencies, I think we have to declare the
scope to "provided" instead of using the default "compile" scope:

e.g.

<dependency>
    <groupId>org.sakaiproject.common</groupId>
    <artifactId>archive-impl</artifactId>
    <version>${sakai.common.version}</version>
    <scope>provided</scope>
</dependency>


If the scope is not set to "provided" then it deploys the JARs in the war.

e.g.

# jar -tf sakai-gradebook2.war | grep archive
WEB-INF/lib/archive-impl-1.2-SNAPSHOT.jar


2. I don't quite understand the "<optional>true</optional>" usage and
if it's needed:

<dependency>
    <groupId>org.sakaiproject.kernel</groupId>
    <artifactId>sakai-kernel-impl</artifactId>
    <version>${sakai.kernel.version}</version>
    <optional>true</optional>
</dependency>

I tried to related what's described here:

http://maven.apache.org/guides/introduction/introduction-to-optional-and-excludes-dependencies.html

... to what we need and don't quite understand it. Maybe you can
explain that to me tomorrow.

Best,
-- Thomas



On Mon, Jan 9, 2012 at 7:55 PM, Jon Gorrono <jpgorrono at ucdavis.edu> wrote:
> I've just committed to trunk changes to the root pom and .classpath
> which should resolve a couple of annoyances/issues with dev mode:
>
> edu-services version is now 1.2-SNAPSHOT to match the 2.9.x branch....
> note that trunk is at 1.3-SNAPSHOT
>
> kernel version is now 1.3.0-SNAPSHOT .. . note that trunk is at 1.4.0-SNAPSHOT
>
> a couple of mock classes have been updated with stubs for some new methods
>
> Another change committed is a is a long overdue revisit to an issue
> Jim Eng discovered some time ago regarding dependencies in dev mode on
> archive api and impl, namely, that these jars are typically
> unavailable in the maven repo since they are placed into the targeted
> tomcat container during the sakai:deploy goal, completely bypassing
> .m2/repository...
>
> (FYI, The archive impl is used to test archiving capabilities in gb2
> without maintaining a bunch of code that mimics the archive service...
> we also use this reasoning to simplify a bunch of mock classes in the
> 'dev' directory branch)
>
> The M2_REPO eclipse classpath variable didn't help get to the jars; so
> the problem was 'addressed' by using another classpath variable in
> eclipse pointing in the tomcat deployment area which could be extended
> to include the jar(s) ... nobody liked it but it was about as creative
> as anyone wanted to get at the time
>
> Simple fix is obvious now, or I am freshly ignorant of an reason this
> wasn't done before: the archive api, archive impl and the kernel-impl
> jars are all just added to the pom
>
> I think I had a bunch of compile time issues doing that before and
> gave up... this time, though, I happened to type in the 'optional'
> dependency tag for kernel impl and the errors vanished (see GRBK-1209
> for deetz)
>
> Hey luck also helps rescue dogs find people so it ain't so bad. :)
>
> Comments and concerns welcome
>
>
>
>
>
>
>
>
> --
> Jon Gorrono
> PGP Key: 0x5434509D -
> http{pgp.mit.edu:11371/pks/lookup?search=0x5434509D&op=index}
> GSWoT Introducer - {GSWoT:US75 5434509D Jon P. Gorrono <jpgorrono -
> www.gswot.org>}
> http{middleware.ucdavis.edu}
> _______________________________________________
> gradebook2-dev mailing list
> gradebook2-dev at collab.sakaiproject.org
> http://collab.sakaiproject.org/mailman/listinfo/gradebook2-dev