[gradebook2-dev] GRBK-485-1 (issue4223043)

mikewenk at gmail.com mikewenk at gmail.com
Mon Mar 7 14:19:15 PST 2011


Looks fine, one comment about consistency.

+1 to merge.


http://codereview.appspot.com/4223043/diff/1/client/src/java/org/sakaiproject/gradebook/gwt/client/gxt/view/panel/MultiGradeContentPanel.java
File
client/src/java/org/sakaiproject/gradebook/gwt/client/gxt/view/panel/MultiGradeContentPanel.java
(right):

http://codereview.appspot.com/4223043/diff/1/client/src/java/org/sakaiproject/gradebook/gwt/client/gxt/view/panel/MultiGradeContentPanel.java#newcode1572
client/src/java/org/sakaiproject/gradebook/gwt/client/gxt/view/panel/MultiGradeContentPanel.java:1572:
*/
Does this method have to do things this way?  It seems like it will
always do the below if its false, but if it ever gets to be true it will
stop checking the registry.  Either it should be consistent or the
constructor/init method should set it once.

http://codereview.appspot.com/4223043/


More information about the gradebook2-dev mailing list