[gradebook2-dev] Requesting input on Gradebook2 SampleInstitutionalAdvisor.submitFinalGrade(...) API

[Thomas Amsler]

Thank you everybody for providing feedback. So far, I cannot think of
a use case where you "really" need the request/response object. I have
a patch that removes the request/response object. I will attach it to
the JIRA later so that you guys have a chance to review it.

Best,
-- Thomas

On Tue, Dec 13, 2011 at 9:43 AM, John Bush <john.bush at rsmart.com> wrote:
> We have three implementations of InstitutionalAdvisor.  It looks like
> the only thing we ever use the response for is setting error status.
> I can't find any usage of request.  There was one case where we wanted
> to write to the response to create a download, but ran into the same
> issues others have spoke of.  In that case, our workaround was to
> create the file in the my workspace and train folks to get it there,
> not ideal but sufficient.
>
> So I don't see any major problem with making this api change for us.
>
> On Mon, Dec 12, 2011 at 11:02 PM, Thomas Amsler <tpamsler at ucdavis.edu> wrote:
>> Take 2 ...
>>
>> For those Institutions that are using the gradebook2 "Final Grade
>> Submission" feature via the InstitutionalAdvisor, I would like to know
>> how you are using the following API:
>>
>> Source:
>> https://source.sakaiproject.org/contrib//gradebook2/trunk/api/src/java/org/sakaiproject/gradebook/gwt/sakai/InstitutionalAdvisor.java
>>
>> API Method:
>> public void submitFinalGrade(List<Map<Column,String>> studentDataList,
>> String gradebookUid, HttpServletRequest request, HttpServletResponse
>> response);
>>
>> In particular, I would like to know if anybody is using the
>> HttpServletRequest and HttpServletResponse method arguments and if so,
>> how you are using them? Also, would it be a problem if we would remove
>> the HttpServletRequest and HttpServletResponse method arguments, and
>> instead use the "normal" REST JSON way to send data back to the
>> client. Maybe change the method signature to something like this:
>>
>> public FinalGradeSubmissionResult
>> submitFinalGrade(List<Map<Column,String>> studentDataList, String
>> gradebookUid);
>>
>> Comments?
>>
>> Best,
>> -- Thomas
>
>
>
> --
> John Bush
> 602-490-0470