[Contrib: Evaluation System] Results of closed evaluations can'tbe viewed by maintains

[Daniel Merino]

Hi everybody.

After going deeply in the code, I have found that the viewable surveys  
for instructors/maintains are affected by the setting "Number of days 
old can an eval be and still be recently closed".

This is, instructors/maintains can view results for their site's surveys 
only if they have been closed in the last X days, when X is set in 
global config options.

I don't know if this is written somewhere in the docs, but I had no 
idea... maybe it could be a good idea to write in the checkbox 
"Instructors in the courses this evaluation is assigned to can view 
results the next X days after it is closed", where X is get of tool's 
configuration.

Thanks a lot.
Best regards.

Daniel Merino escribió:
> Hi, Nicola and everybody.
>
> We apply in all our sites (projects and courses) the permissions 
> recommended in this page: 
> https://confluence.sakaiproject.org/display/EVALSYS/Setting+up+permissions 
>
>
> That is: our teachers/maintains have eval.assign.evaluation, 
> eval.be.evaluated and eval.write.template. Our access/students have 
> only eval.take.evaluation.
>
> Our idea is that, if one evaluation is configured to allow viewing 
> results for maintains and it can be done by access users at one site, 
> maintains users of this site can view results once the evaluation has 
> been closed. We don't use instructor-specific questions and we don't 
> need external users to view results neither.
>
> I have tested this issue in projects and courses, and it seems to 
> happen in both. If you need more info, I have a test environment where 
> I can change configuration and debug code or database values.
>
> It's odd, as Adam says, that this is working in other places. We are 
> using Evalsys 1.3.0. Could this be working in 1.3.x?
>
> Thanks a lot for your help.
> Best regards.
>
> Nicola Monat-Jacobs escribió:
>> Daniel -
>>
>> Do your 'maintain' folks have eval.be.evaluated? Are they like 
>> instructors in the project sites or are they more like admins that 
>> should see the report but aren't to be evaluated? (Although if you 
>> don't have any instructor-specific qs then this isn't really a 
>> meaningful distinction.)
>>
>> What I'm saying is, if they have eval.be.evaluated and if you allow 
>> instructors access to see the reports of evaluations deployed to 
>> their classes, then I imagine this would work. Otherwise, I don't 
>> think it would.
>>
>> I've worked with other clients who have evaluation admins that are 
>> NOT in the courses and yet still need to see results of certain 
>> courses' evaluations even if they haven't created those evaluations 
>> themselves. This is, of course, a bit tricky and we've done some work 
>> with Eval Hierarchy > Assign Users to make this work. But I don't 
>> think that's what you're after here.
>>
>> Mostly, evalsys looks at if you have eval.be.evaluated to determine 
>> if it should treat you as an 'instructor' in a course's evaluations 
>> but there might be some places where the 'Instructor' role is 
>> hard-coded.
>>
>>
>> On Tue, Mar 5, 2013 at 4:40 AM, Adam Marshall 
>> <adam.marshall at it.ox.ac.uk <mailto:adam.marshall at it.ox.ac.uk>> wrote:
>>
>>     We use 1.3 and regularly share results and we don't seem to have
>>     fixed this in order to get it to work. Odd.
>>
>>     adam
>>
>>
>>
>>     -----Original Message-----
>>     From: evaluation-bounces at collab.sakaiproject.org
>>     <mailto:evaluation-bounces at collab.sakaiproject.org>
>>     [mailto:evaluation-bounces at collab.sakaiproject.org
>>     <mailto:evaluation-bounces at collab.sakaiproject.org>] On Behalf Of
>>     Daniel Merino
>>     Sent: 05 March 2013 11:12
>>     To: evaluation at collab.sakaiproject.org
>>     <mailto:evaluation at collab.sakaiproject.org>; sakai-dev
>>     Subject: [Contrib: Evaluation System] Results of closed
>>     evaluations can't be viewed by maintains
>>
>>     Hi everybody.
>>
>>     Since we started to use Evaluation System 1.3.0, the configuration
>>     option that allows users to see the results of surveys in a site
>>     where they are maintains has never worked for us. No matter if it
>>     is set in Admin's global configuration or in local survey's
>>     options, maintain users only can see results in surveys where they
>>     are owners.
>>
>>     I have taken a look on JIRA but I can't find if this has been
>>     solved somewhere. Also, looking in the source code I don't
>>     understand it very well, as it seems to me that this option is
>>     hardcoded in ControlEvaluationsProducer.java in the next line:
>>
>>     List<EvalEvaluation> evals =
>>     
>> evaluationSetupService.getVisibleEvaluationsForUser(commonLogic.getCurrentUserId(), 
>>
>>     false, false, true);
>>
>>     where the second "false" is showNotOwned param.
>>
>>     My questions: is working this feature in 1.3.0? If it is not and
>>     it has been patched later, do you know where is the related JIRA
>>     in which I could start to try to fix it?
>>
>>     Many thanks in advance.
>>     Best regards.
>>     --
>>     Daniel Merino Echeverría
>>     daniel.merino at unavarra.es <mailto:daniel.merino at unavarra.es>
>>     Gestor de teleformación - Centro Superior de Innovación Educativa.
>>     Tfno: 948-168489 - Universidad Pública de Navarra.
>>     _______________________________________________
>>     evaluation mailing list
>>     evaluation at collab.sakaiproject.org
>>     <mailto:evaluation at collab.sakaiproject.org>
>>     http://collab.sakaiproject.org/mailman/listinfo/evaluation
>>
>>     TO UNSUBSCRIBE: send email to
>>     evaluation-unsubscribe at collab.sakaiproject.org
>>     <mailto:evaluation-unsubscribe at collab.sakaiproject.org> with a
>>     subject of "unsubscribe"
>>     _______________________________________________
>>     evaluation mailing list
>>     evaluation at collab.sakaiproject.org
>>     <mailto:evaluation at collab.sakaiproject.org>
>>     http://collab.sakaiproject.org/mailman/listinfo/evaluation
>>
>>     TO UNSUBSCRIBE: send email to
>>     evaluation-unsubscribe at collab.sakaiproject.org
>>     <mailto:evaluation-unsubscribe at collab.sakaiproject.org> with a
>>     subject of "unsubscribe"
>>
>>
>

-- 
Daniel Merino Echeverría
daniel.merino at unavarra.es
Gestor de teleformación - Centro Superior de Innovación Educativa.
Tfno: 948-168489 - Universidad Pública de Navarra.
--
Cuando uno es incapaz de reirse de si mismo, ha llegado el momento de 
que los otros se rían de él. (Thomas Szasza)