[Contrib: Evaluation System] Template visibility set by template's owner

[Adam Marshall]

We would NOT want to allow users to create public templates so I would hope that it would still be possible to prevent non admin users from doing this.

Our reasoning is that everybody sees the list of public templates the value of public templates are diminished if there is a really long list of ill thought out examples. If this is the case, people will ignore all public offerings.

We've introduced a transfer ownership of template facility to aid template sharing. We're running a really old version of evals and I don't think we've had the resources to contribute this patch back yet.

adam

-----Original Message-----
From: evaluation-bounces at collab.sakaiproject.org [mailto:evaluation-bounces at collab.sakaiproject.org] On Behalf Of Daniel Merino
Sent: 01 August 2013 13:14
To: evaluation at collab.sakaiproject.org
Subject: [Contrib: Evaluation System] Template visibility set by template's owner

Hi everybody.

I have fixed in my local Evalsys what I think it's a bug, but it seems that it could be a feature. I would be very grateful if somebody could clarify this to me.

In Admin settings, template's visibility can be configured to be public, private (only visible by template's owner) or configurable by owner. 
This third case is what I have been testing and it doesn't work, as users can't change visibility in their templates. Only admin user can edit templates and set them as private or public.

This behaviour is in the code at ModifyTemplateProducer.java (1) and EvalAuthoringServiceImpl.java (2). Current user is verified to be admin user and in any other case, template's visibility can not be changed.

We think that this is a bug so I have fixed it removing the admin user verification. Instead of this, I verify that current user is template's owner to allow the visibility change.

My changes cause a fail in Evalsys tests (3), as admin user is specifically tested to be the only one that can change visibility in templates.

Please, could you tell me if I am missing something here? I think that template's owner should be able to set this and I have a patch to change this if you agree with me.

Thanks in advance.
Best regards.


1)
https://source.sakaiproject.org/contrib//evaluation/trunk/tool/src/java/org/sakaiproject/evaluation/tool/producers/ModifyTemplateProducer.java
2)
https://source.sakaiproject.org/contrib//evaluation/trunk/impl/src/java/org/sakaiproject/evaluation/logic/EvalAuthoringServiceImpl.java
3) Tests in error: 
testSaveTemplate(org.sakaiproject.evaluation.logic.EvalAuthoringServiceImplTest): 
Only admins can set template (Template maint public) sharing to public
--
Daniel Merino Echeverría
daniel.merino at unavarra.es
Gestor de teleformación - Centro Superior de Innovación Educativa.
Tfno: 948-168489 - Universidad Pública de Navarra.
_______________________________________________
evaluation mailing list
evaluation at collab.sakaiproject.org
http://collab.sakaiproject.org/mailman/listinfo/evaluation

TO UNSUBSCRIBE: send email to evaluation-unsubscribe at collab.sakaiproject.org with a subject of "unsubscribe"