[Contrib: Evaluation System] TODO code in evalsys tool pertaining to RSF v 0.7.3

[Lovemore Nalube]

Hi everyone
 
Compliments of the season to you all.
 
I am investigating why some blocked/grouped scales do not show ideal
colouring when flagged todo so. As a result I've see the cause to the
"*NULL*" value given to some scales in the "IDEAL" column of the
EVAL_SCALE table. Does anyone know why this value  is a string value and
simply not NULL? 
 
Direct reference to this value is accompanied by these TODO notes:
 
// TODO - hopefully this if block is only needed temporarily until RSF
0.7.3
 
found in this section of code (LocalTemplateLogic.java (
https://source.sakaiproject.org/contrib/evaluation/trunk/tool/src/java/org/sakaiproject/evaluation/tool/LocalTemplateLogic.java
) from line 180 ):
 
   // SCALES
 
   public EvalScale fetchScale(Long scaleId) {
      EvalScale scale = authoringService.getScaleById(scaleId);
      // TODO - hopefully this if block is only needed temporarily
until RSF 0.7.3
      if (scale.getIdeal() == null) {
         scale.setIdeal(EvalToolConstants.NULL);
      }
      return scale;
   }
 
   public void saveScale(EvalScale scale) {
      // TODO - hopefully this if block is only needed temporarily
until RSF 0.7.3
      if (scale.getIdeal() != null &&
            scale.getIdeal().equals(EvalToolConstants.NULL)) {
         scale.setIdeal(null);
      }
      authoringService.saveScale(scale,
commonLogic.getCurrentUserId());
   }
 
   /**
    * Hides a scale (this will make the scale inaccessible to users)
    * 
    * @param scaleId the unique id of a scale
    */
   public void hideScale(Long scaleId) {
      EvalScale scale = fetchScale(scaleId);
      scale.setHidden(true);
      authoringService.saveScale(scale,
commonLogic.getCurrentUserId());
   }
 
   public void deleteScale(Long id) {
      authoringService.deleteScale(id,
commonLogic.getCurrentUserId());
   }
 
   public EvalScale newScale() {
      EvalScale currScale = new
EvalScale(commonLogic.getCurrentUserId(), 
            null, EvalConstants.SCALE_MODE_SCALE, 
            EvalConstants.SHARING_PRIVATE, Boolean.FALSE);
     
currScale.setOptions(EvalToolConstants.defaultInitialScaleValues);
      currScale.setIdeal(EvalToolConstants.NULL); // TODO - temp until
RSF 0.7.3
      return currScale;
   }
 
Evalsys is running RSF v 0.7.4 so are these TODO's safe to remove? 
 
 
--
Lovemore Nalube
OLE Developer (Vula)
University of Cape Town
http://www.cet.uct.ac.za/LovemoreN



 

###
UNIVERSITY OF CAPE TOWN 

This e-mail is subject to the UCT ICT policies and e-mail disclaimer
published on our website at
http://www.uct.ac.za/about/policies/emaildisclaimer/ or obtainable from
+27 21 650 9111. This e-mail is intended only for the person(s) to whom
it is addressed. If the e-mail has reached you in error, please notify
the author. If you are not the intended recipient of the e-mail you may
not use, disclose, copy, redirect or print the content. If this e-mail
is not related to the business of UCT it is sent by the sender in the
sender's individual capacity.

###
 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://collab.sakaiproject.org/pipermail/evaluation/attachments/20110104/ba94e51e/attachment.html