[Contrib: Evaluation System] getFilteredEvalGroupsForUser method?

Wed Jun 9 06:17:33 PDT 2010

Thanks for making that jira.

Are you also refactoring the other 2 methods located in the same area in the
code (marked with FIXME in the code)? Those have the same problems.

What is the flag for enabling "isEvalGroupPublished" checks (or do we need a
flag? maybe it makes sense to only look at published sakai sites)?
-AZ

On Wed, Jun 9, 2010 at 8:42 AM, Lovemore Nalube
<lovemore.nalube at uct.ac.za>wrote:

>  Hi
>
> The flag for filtering groups is called: "Only show sites like a user's
> current site in the assignments view (UCT)".
>
> The isEvalGroupPublished is actually running in trunk (sorry I said
> otherwise in my last email). I've made a Jira to refactor it
> http://jira.sakaiproject.org/browse/EVALSYS-942
>
> Thanks for the technical review.
>
>  --
> Lovemore Nalube
> OLE Developer (Vula)
> University of Cape Town
> http://www.cet.uct.ac.za/LovemoreN
>
>
>
> >>> On 6/9/2010 at 12:02 PM, in message <
> AANLkTime9cS4c4dPG8znEHr9wSjimxj_jIaFQnFVIgTA at mail.gmail.com>, Aaron
> Zeckoski <azeckoski at unicon.net> wrote:
>    Which flag (please copy and paste the text that is next to it)?
>
> The code ignores the fact that we have 3 types of groups that we use. All
> groups are transformed in "EvalGroup" before they are actually used (in
> common logic) but before that we allow:
> 1) Sakai sites and groups
> 2) Internal adhoc groups
> 3) EvalGroupsProvider defined groups
>
> This code (like the other method I mentioned) does not support Sakai
> groups/sections, adhoc groups, or provided groups.
> The ENTIRE point of commons logic is to allow single method calls which
> merge these multiple group types down into EvalGroup (and to handle EvalUser
> and permissions in the same way).
> This code was added without taking that into account and simply passes
> through to methods in ExternalLogic (which is the class for handling getting
> data from one of these sources - Sakai).
>
> It is also implemented in a pretty costly way (in that each time you want
> to check if a group is published you have to fetch the site, not awful if in
> the cache already but the failed lookup attempt for all the non-site cases
> is going to be bad). If it were me I would have simply added a boolean to
> the EvalGroup class which is default=true and then updated it to false for
> Sakai sites that were not published. This is less intrusive in the code in
> general and avoids the extra lookup (you already have that data when the
> site was first looked up). My recommendation is that you change the code to
> work like this.
>
> I updated the code comment on the commons service to make this more clear..
>
> -AZ
>
>
> On Wed, Jun 9, 2010 at 3:47 AM, Lovemore Nalube <lovemore.nalube at uct.ac.za
> > wrote:
>
>>  Hi Aaron
>>  In the assign evaluation screen this method is called to only show eval
>> groups that are like the current site a user is in (and if it is a course
>> site show current year sites). This is a UCT implementation based on;
>>
>>    1. the need to shorten the list of sites a user is presented with esp.
>>    if they have a huge membership enrolment
>>    2. the need to give relevant sites. A lecturer will create a
>>    course-type evaluation to assign it to course sites in the current year. So
>>    there's no need to show collab or project sites.
>>
>> This is not used by default as there is a UCT specific global flag under
>> the Eval Settings.
>>  Please shed light on how it is implemented incorrectly. I am keen to get
>> it fixed.
>>  Thanks
>>   --
>> Lovemore Nalube
>> OLE Developer (Vula)
>> University of Cape Town
>> http://www.cet.uct.ac.za/LovemoreN
>>
>>
>>
>>  >>> On 6/8/2010 at 8:00 PM, in message <
>> AANLkTilCNbgQ5Mk18goG-XlS4KAlNBI8g1YrUs8JsqOM at mail.gmail.com>, Aaron
>> Zeckoski <azeckoski at unicon.net> wrote:
>>     Same question for this method. Is this actually being used by anyone
>> and if so what is it supposed to do?
>> I can't understand what the comment means:
>> "Get a list of all eval groups that a user has a specific permission
>> in that are of the same as this site"
>>
>> It is implemented wrong so if it is not needed I would like to remove it.
>>
>> public List<EvalGroup> getFilteredEvalGroupsForUser(String userId,
>> String permission, String currentSiteId) {
>> ...
>>
>> -AZ
>>
>>
>> --
>> Aaron Zeckoski - Software Engineer - http://tinyurl.com/azprofile
>> _______________________________________________
>> evaluation mailing list
>> evaluation at collab.sakaiproject.org
>> http://collab.sakaiproject.org/mailman/listinfo/evaluation
>>
>> TO UNSUBSCRIBE: send email to
>> evaluation-unsubscribe at collab.sakaiproject.org with a subject of
>> "unsubscribe"
>>
>> ###
>>
>> UNIVERSITY OF CAPE TOWN
>>
>> This e-mail is subject to the UCT ICT policies and e-mail disclaimer
>> published on our website at
>> http://www.uct.ac.za/about/policies/emaildisclaimer/ or obtainable from
>> +27 21 650 4500. This e-mail is intended only for the person(s) to whom it
>> is addressed. If the e-mail has reached you in error, please notify the
>> author. If you are not the intended recipient of the e-mail you may not use,
>> disclose, copy, redirect or print the content. If this e-mail is not related
>> to the business of UCT it is sent by the sender in the sender's individual
>> capacity.
>>
>> ###
>>
>
>
>
> --
> Aaron Zeckoski - Software Engineer - http://tinyurl.com/azprofile
>
>  ###
>
> UNIVERSITY OF CAPE TOWN
>
>  This e-mail is subject to the UCT ICT policies and e-mail disclaimer
> published on our website at
> http://www.uct.ac.za/about/policies/emaildisclaimer/ or obtainable from
> +27 21 650 4500. This e-mail is intended only for the person(s) to whom it
> is addressed. If the e-mail has reached you in error, please notify the
> author. If you are not the intended recipient of the e-mail you may not use,
> disclose, copy, redirect or print the content. If this e-mail is not related
> to the business of UCT it is sent by the sender in the sender's individual
> capacity.
>
>  ###
>

-- 
Aaron Zeckoski - Software Engineer - http://tinyurl.com/azprofile
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://collab.sakaiproject.org/pipermail/evaluation/attachments/20100609/574bf681/attachment.html 