[Contrib: Evaluation System] Request for review - Extend administrate-search results to show the evaluation owner
Lovemore Nalube
lovemore.nalube at uct.ac.za
Fri Jul 9 05:04:53 PDT 2010
Hi
EVALSYS-962 (Inefficient lookup) is a bug fix and would lead to inefficient database calls if this patch is not in RC. No new feature is included. +1 to having this in RC.
EVALSYS-959 (Adding an owner column to the search results) is not a bug fix and does not have to be in RC. In my opinion it does not qualify as a new feature that would confuse new adopters as it is a self-explanatory, simple column in a table. @Jim I understand how trivial this column would be to Umich but does it warrant a global setting? The settings page is already so full. Rather (if we have to) we put a form checkbox to toggle showing the owner column. Attached is a screen shot of this idea.
EVALSYS-963 (Show a readable group name) +1 to having that in RC. For code review, see http://source.sakaiproject.org/viewsvn/?view=rev&rev=69059&root=contrib
:)
--
Lovemore Nalube
OLE Developer (Vula)
University of Cape Town
http://www.cet.uct.ac.za/LovemoreN
>>> On 7/8/2010 at 6:09 PM, in message <D86B0652-785E-4047-8AAB-EAA17EC13B2C at umich.edu>, Jim Eng <jimeng at umich.edu> wrote:
I think EVALSYS-959 should be committed to trunk, though it might be better to control whether the owner is shown with a setting. At Michigan, all evals are owned by admin, so this column is not useful here. But I understand that for many other adopters, the owner is very significant and should be available in that display.
On the other hand, for adopting institutions that have evals from other sources than we do, showing a GUID that means nothing to the user is a BUG! BUG! BUG! that should be fixed in 1.3.0RC. So +1 to including http://jira.sakaiproject.org/browse/EVALSYS-963 in trunk and the 1.3.0RC branch if a good fix is provided.
Jim
On Jul 8, 2010, at 11:33 AM, Nicola Monat-Jacobs wrote:
> For me, the relevant aspect of this discussion is:
>
>> I feel it may be necessary to have this in the 1.3.0RC, what do you think?
>
> Lovemore - did you mean both EVALSYS-959 and EVALSYS-962 or just EVALSYS-962?
>
> Do these issues strikes people as bugs currently effecting users of 1.3.0RC that should be fixed, or do they describe new functionality that might confuse users/testers who are expecting a feature-stable RC?
>
> I think EVALSYS-959 is definitely a new feature, but what about EVALSYS-962?
>
> Thanks,
> Nicola
>
>
>
> On Jul 2, 2010, at 4:27 PM, Aaron Zeckoski wrote:
>
>> Looks fairly safe based on the description. Is there a downside or
>> possible performance hit I am missing?
>> -AZ
>>
>> On Fri, Jul 2, 2010 at 3:50 PM, Lovemore Nalube
>> <lovemore.nalube at uct.ac.za> wrote:
>>> Dear PMC Team
>>>
>>> Kindly review this Jira and it's corresponding patch
>>> http://jira.sakaiproject.org/browse/EVALSYS-959 Screenshots are included and
>>> the fix patch is called: EVALSYS-959-tool-withOwnerUsername.diff
>>>
>>> As Jim suggested, I am copying the list in case anyone else wants to have a
>>> look.
>>>
>>> Thanks
>>>
>>>
>>> --
>>> Lovemore Nalube
>>> OLE Developer (Vula)
>>> University of Cape Town
>>> http://www.cet.uct.ac.za/LovemoreN
>>>
>>>
>>> ###
>>>
>>> UNIVERSITY OF CAPE TOWN
>>>
>>> This e-mail is subject to the UCT ICT policies and e-mail disclaimer
>>> published on our website at
>>> http://www.uct.ac.za/about/policies/emaildisclaimer/ or obtainable from +27
>>> 21 650 4500. This e-mail is intended only for the person(s) to whom it is
>>> addressed. If the e-mail has reached you in error, please notify the author.
>>> If you are not the intended recipient of the e-mail you may not use,
>>> disclose, copy, redirect or print the content. If this e-mail is not related
>>> to the business of UCT it is sent by the sender in the sender's individual
>>> capacity.
>>>
>>> ###
>>>
>>
>>
>>
>> --
>> Aaron Zeckoski - Software Engineer - http://tinyurl.com/azprofile
>> _______________________________________________
>> evaluation mailing list
>> evaluation at collab.sakaiproject.org
>> http://collab.sakaiproject.org/mailman/listinfo/evaluation
>>
>> TO UNSUBSCRIBE: send email to evaluation-unsubscribe at collab.sakaiproject.org with a subject of "unsubscribe"
>
> _______________________________________________
> evaluation mailing list
> evaluation at collab.sakaiproject.org
> http://collab.sakaiproject.org/mailman/listinfo/evaluation
>
> TO UNSUBSCRIBE: send email to evaluation-unsubscribe at collab.sakaiproject.org with a subject of "unsubscribe"
>
>
_______________________________________________
evaluation mailing list
evaluation at collab.sakaiproject.org
http://collab.sakaiproject.org/mailman/listinfo/evaluation
TO UNSUBSCRIBE: send email to evaluation-unsubscribe at collab.sakaiproject.org with a subject of "unsubscribe"
###
UNIVERSITY OF CAPE TOWN
This e-mail is subject to the UCT ICT policies and e-mail disclaimer published on our website at http://www.uct.ac.za/about/policies/emaildisclaimer/ or obtainable from +27 21 650 4500. This e-mail is intended only for the person(s) to whom it is addressed. If the e-mail has reached you in error, please notify the author. If you are not the intended recipient of the e-mail you may not use, disclose, copy, redirect or print the content. If this e-mail is not related to the business of UCT it is sent by the sender in the sender's individual capacity.
###
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://collab.sakaiproject.org/pipermail/evaluation/attachments/20100709/f82829c1/attachment-0001.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: evals search.JPG
Type: image/jpeg
Size: 15315 bytes
Desc: not available
Url : http://collab.sakaiproject.org/pipermail/evaluation/attachments/20100709/f82829c1/attachment-0001.jpe
More information about the evaluation
mailing list