[Contrib: Evaluation System] EVALSYS-967
Aaron Zeckoski
azeckoski at unicon.net
Fri Aug 27 09:14:10 PDT 2010
I think it makes sense and there is no problem really. The only things
to be aware of is that it is bending the permissions slightly be
allowing someone to see courses they normally could not but I don't
think that is a major issue since the only people who can see this are
admins.
-AZ
On Fri, Aug 27, 2010 at 11:15 AM, Nicola Monat-Jacobs
<nicola at longsight.com> wrote:
> Thanks for taking a look Aaron.
>
> Yes, the change I'm going for is to show the user's assigned groups (checked or not) and also show the other groups that are already part of this node that in the current code, the user does not see.
>
> It strikes me that in most use-cases, the person viewing this screen is a sakai admin of some sort, and just because they're not enrolled in a site, doesn't mean they don't have access to it.
>
> Perhaps there's a way to show those other groups and make their checkboxes disabled, so the current user can see them and confirm they're there but can't mess with them?
>
>> By setting them to true in assignedGroups map you are making them
>> checked in the interface (such that submitting would make them part of
>> the assignedGroupsIds in a future load of the page).
>
> "them" in this context is the assignedGroupsId set - is setting them to true a bad thing since we know they're already part of the node? Or is it that I'll encounter problems when trying to submit because the current user doesn't have access to submit with those nodes? (Now that you mention it....)
>
> Nicola
>
> On Aug 26, 2010, at 2:36 PM, Aaron Zeckoski wrote:
>
>> The assignedGroupsId set is an indicator of the groups assigned to
>> that node. The set from getEvalGroupsForUser are the possible nodes
>> which can be assigned.
>> By setting them to true in assignedGroups map you are making them
>> checked in the interface (such that submitting would make them part of
>> the assignedGroupsIds in a future load of the page).
>>
>> It looks like the change you are going for here is to force all the
>> assigned groups to stay checked and appear even if the user does not
>> have access to them.
>>
>> Is that what you wanted to do? (I ask because the JIRA description
>> seems to say something else)
>> -AZ
>>
>>
>> On Thu, Aug 26, 2010 at 5:02 PM, Nicola Monat-Jacobs
>> <nicola at longsight.com> wrote:
>>> Can someone take a quick look at my proposed patch for
>>> http://jira.sakaiproject.org/browse/EVALSYS-967 ?
>>>
>>> It's really an interim solution, but it's definitely been an annoyance in the past.
>>>
>>> Thanks,
>>> Nicola
>>> _______________________________________________
>>> evaluation mailing list
>>> evaluation at collab.sakaiproject.org
>>> http://collab.sakaiproject.org/mailman/listinfo/evaluation
>>>
>>> TO UNSUBSCRIBE: send email to evaluation-unsubscribe at collab.sakaiproject.org with a subject of "unsubscribe"
>>>
>>
>>
>>
>> --
>> Aaron Zeckoski - Software Engineer - http://tinyurl.com/azprofile
>
>
--
Aaron Zeckoski - Software Engineer - http://tinyurl.com/azprofile
More information about the evaluation
mailing list