[cle-release-team] Maven inconsistencies

[Beth Kirschner]

Hi release team,

One of our pioneering developers (Kent Fitzgerald, who generates our internal builds), did an audit of our Sakai 2.9.1 code base and found several inconsistencies in the maven pom.xml files. I can create a set of JIRAs, but thought I'd first raise these for discussion first. I'm not sure if there's a script that updates some of these when we migrate to a new release or if this is done manually?

- Beth


* Common	- The module version in common/pom.xml is 1.2.1. But in common/ddl/pom.xml all references to org.sakaiproject.common are specified with a version 1.2-SNAPSHOT.

* edu-services/cm-service/cm-authz-synchronizer/pom.xml:7:        <version>2.7.0-SNAPSHOT</version>
  This file has a parent version of 2.7.0-SNAPSHOT, but the module version is 1.2.1.

* edu-services/cm-service/cm-impl/integration-test/pom.xml:7:        <version>1.0-SNAPSHOT</version>
  This file has a parent version of 1.0-SNAPSHOT, but the module version is 1.2.1.

* entitybroker/deployer/pom.xml:20:        <version>1.5-SNAPSHOT</version>
  This file has a parent version of 1.5-SNAPSHOT but the module version is 1.5.1

* jobscheduler/scheduler-configurable-job-test-component/pom.xml:9:        <version>2.9-SNAPSHOT</version>
  Version of module is 2.9.1 but the files reference a snapshot.

* jobscheduler/scheduler-configurable-job-test-component-shared/pom.xml:9:        <version>2.9-SNAPSHOT</version>
  Version of module is 2.9.1 but the files reference a snapshot.
	
* Lessonbuilder - main pom.xml has commented out versions which perhap should probably be removed (lines 38-41)

* lessonbuilder/hbm/src/ddl/pom.xml:13:        <version>1.4.1-SNAPSHOT</version>
  Parent version references 1.4.1-SNAPSHOT, but module is defined as 1.4.1

* lessonbuilder/pom.xml:71:         <sakai.basiclti.version>2.0-SNAPSHOT</sakai.basiclti.version>
  Should this line be removed (or commented out) and just pull the current version from master/pom.xml?
  
* lessonbuilder/tool/src/ddl.hold/pom.xml:8:        <version>1.3-SNAPSHOT</version>
  parent version of this pom is set as 1.3-SNAPSHOT, but the version of the module is 1.4.1

* portal/portal-portlet-tool/tool/pom.xml:10:        <version>2.9-SNAPSHOT</version>

* search/search-test/test-1.5/pom.xml:7:    <version>1.3.0-SNAPSHOT</version>
  parent version is set to 1.3.0-SNAPSHOT but the module version is 1.4.1

* shortenedurl/ddl/pom.xml:15: <version>1.1-SNAPSHOT</version>
  Tag is versioned as 1.1.1 but this file refers to parent 1.1-SNAPSHOT

* sitestats (2.3.4) -- https://source.sakaiproject.org/svn/sitestats/tags/sitestats-2.3.4/sitestats-2.3.x/  
  This looks like a mistake with the 2.3.4 tag of sitestats (notice sitestats-2.3.x sub-directory)?
 
* sitestats/sitestats-impl-hib/src/ddl/pom.xml:17:    <version>2.2-SNAPSHOT</version><!-- sitestats.version -->
  Module version is 2.3.4 but these poms have a parent version of 2.2-SNAPSHOT specified