[cle-release-team] BasicLTI 2.1.0 -> 2.9.x: ticket review
Beth Kirschner
bkirschn at umich.edu
Mon Apr 29 09:31:38 PDT 2013
Hi Chuck & release-team,
A few quick questions/comments:
1) Is Basic LTI included in any sort of formal Sakai QA testing?
2) Zhen just fixed BLTI-209 -- is it too late to merge this?
3) BLTI-151 shows a fix version of 2.1, and it looks like the 2.1.x branch was cut after BLTI-151 was committed to trunk. So it looks like it's in 2.1 unless it was backed out and I didn't notice that.
Thanks,
- Beth
On Apr 9, 2013, at 7:46 PM, Charles Severance <csev at umich.edu> wrote:
> Anthony,
>
> Here are my notes on your notes - comments from all are welcome...
>
> I have no intention of releasing the Site Info (SAK-22108) and Provider Realm functionality (BLTI-151) as part of Sakai 2.9.2 / LTI 2.1.0. Those JIRAs (and related) should have a later "fix version" to capture the notion that they are still partially complete in trunk and in-progress and not part of this release.
>
> I made this choice because I wanted to keep the scope of 2.1.0 relatively safe and simple and focused on that which can be fixed "within-LTI" without spidering dependencies throughout Sakai and Kernel. So 2.9.2 Site Info will not have 100% of the functionality of the trunk. I did this very much on purpose to keep the complexity low for 2.1.0 and make testing and conversions more in line with the expectations of a dot release. I figured that once LTI 2.1.0 / Sakai 2.9.2 are out - then we can come back to these two areas that cut across multiple parts of Sakai and involve multiple teams. I wanted to limit the number of moving parts for this release. I also wanted to give Michigan plenty of time to merge their changes and my changes together and test them fully without rushing to make a 2.9.2. deadline.
>
> Site-Manage-Changes
>
> If you check out Sakai 2.9.x and LTI 2.1.x, you will not see the new functionality in SAK-22108. Both the "Manage External Tools" link in Site Info and the ability to use the "Edit Tools" to place predefined LTI tools in the left nav bar are neither active nor available.
>
> So this is not planned to be pushed into 2.9.2 unless Michigan separately decides to to upgrade Site Manage for 2.9.2. After 2.9.2 / 2.1.0 the needed support will be in-place within LTI so it will be a simple matter to upgrade Site Manage at a future date. I prefer to de-couple these two changes. If Zhen is actually planning on putting all the new Site Info functionality into 2.9.2 - that is fine - LTI 2.1.0 will work with or without the latest Site Info capability - it is a separate effort from the LTI indie release.
>
> https://jira.sakaiproject.org/browse/SAK-22108
> Make basiclti tools selectable as external tools inside Site Info Edit Tools pages
>
> The fix date for SAK-22108 should stay 2.10
>
> https://jira.sakaiproject.org/browse/BLTI-205
> The LTI admin tool is missing options for some user-defined parameters
>
> The necessary data model changes for BLTI-205 are already in the conversion scripts - but the changes were poorly defined / worded in the JIRA text I reworded the JIRA. The site-manage commit, r119500, included in BLTI-205 is mis-marked - it is not a BLTI-commit - it is a site-manage commit and will not appear until Site Manage is upgraded post 2.9.2.
>
> Provider / Realm Changes
>
> These are partially complete in the trunk of Sakai + the trunk of LTI and it is *not* my intention to push all of the changes into 2.9.2 / 2.1.0. I wanted to avoid kernel changes and a kernel conversion script in 2.9.2 / 2.1.0. The provider code in LTI is in 2.1.0 but latent unless properties are turned on. Again, once 2.9.2 / 2.1.0 is out the door, we are in a better position to move the changes outside of LTI forward. The LTI code will be ready when Kernel is updated and the LTI code can be activated via a property. Schools that want to accelerate deployment can do the conversions by hand as I assume some have done.
>
> https://jira.sakaiproject.org/browse/BLTI-151
> Ability for the provider to map incoming LIS roles to an equivalent Sakai site role
>
> BLTI-151 and related JIRAs should be updated to have a fix version of LTI 2.2.0 or Sakai 2.10. We may decide to pull these into a 2.9.3 - and if we do, it will have far less complexity than trying to push it all into 2.9.2. All of the code that is in trunk of LTI (i.e. r104747 and similar) can be left in 2.1.0 - it is latent and including it in 2.1.0 makes putting the rest of BLTI-151 into a future Sakai release much easier (few moving parts)
>
> One Thing I Missed - Thanks
>
> https://jira.sakaiproject.org/browse/BLTI-208
> Drop the "required" constraint on launch, consumerkey, and secret tool fields
>
> These three ALTER statements were not in the conversion scripts below. I added the three ALTER statements in r122489 - so that now needs to be merged into 2.1.x
>
> Conversion Scripts
>
> The JIRAs listed in the conversion scripts are either (a) already reflected in the 2.1.0 conversion scripts or (b) needed for BLTI-151 and related JIRAs which are not part of 2.1.0. The proper way to test the conversion is to take a Sakai 2.9.1/LTI 2.0.0 and upgrade it to Sakai 2.9.2 / LTI 2.1.0 and run the conversion scripts. Interim UMich versions / schema changes are all rolled up.
>
> The conversion scripts are documented here:
>
> https://confluence.sakaiproject.org/display/LTI/LTI+-+Release+2.1.0+Notes
>
> and then scroll down and look here:
>
> https://source.sakaiproject.org/svn/basiclti/trunk/notes/basiclti-2.1.0/sakai_basiclti_2_1_0_oracle.sql
> https://source.sakaiproject.org/svn/basiclti/trunk/notes/basiclti-2.1.0/sakai_basiclti_2_1_0_mysql.sql
>
> Did I put these in the wrong place - or at they the wrong format?
>
> By the way, these are *not* part of autoDDL - with FOORM, when autoDDL is on, the ALTER commands are run immediate when an out-of-date schema is detected.
>
> Other Notes
>
> https://jira.sakaiproject.org/browse/BLTI-217
> https://jira.sakaiproject.org/browse/LSNBLDR-205
> Error in flow between Lessons and LTI
>
> There is no dependency here. There was never a bug or needed change in Lesson Builder. The problem was completely within LTI and is fixed in 2.1.0. The JIRAs properly reflect this.
>
> Conclusion
>
> You did catch my miss of BLTI-208 - so we need to merge r119890 into 2.1.x before proceeding. Once that is done, we may also need to move the conversion scripts if they are in the wrong place.
>
> Because of my plan to delay SAK-22108 (Site Info UI changes) and BLTI-151 (Provider Realm Changes) to post-2.9.2, my review of your review suggests that 2.1.x is ready for release other than the changes above. The only other outstanding JIRA issues are the "new property" changes JIRAs you propose.
>
> Comments welcome.
>
>
> On Apr 9, 2013, at 11:53 AM, Anthony Whyte wrote:
>
>> BasicLTI 2.1.0 is slated for inclusion in CLE 2.9.2. In preparation for merging I've reviewed 53 BasicLTI 2.1tickets plus related tickets [1]. I've looked at each ticket's status, associated commit stream, dependency on other tickets (i.e., other module changes required in support of the work) and whether or not it introduces a new property or requires a conversion script change. Anyone who has worked on basiclti trunk should review the summary below as it includes questions and TODOs and is based on Jira ticket info, which is subject to the frailties of the human condition.
>>
>> Next steps (at a minimum):
>> 1. Review: csev, zqian et al review my review, especially as it relates to questions regarding unfinished work (if any), supporting merges required from other modules (e.g., site-manage, maybe the kernel), conversion script changes, new properties, basiclti code in trunk that needs merging, etc.
>> 2. Merge: merge site-manage changes, etc.
>> 3. POM tweeks: update 2.9.x master pom; update basiclti 2.1.x base pom <parent>
>> 4. Conversion scripts: update trunk and 2.9.x /reference conversion scripts for 2.9.2
>> 5. Properties: update 2.9.x /config default.sakai.properties
>>
>> Some of these steps may require the creation of new SAK tickets.
>>
>> Cheers,
>>
>> Anth
>>
>>
>> Commit stream
>> The 2.1.x branch was created created 19 March 2013 from trunk, r121473; trunk updated to 2.2-SNAPSHOT, r21474. All trunk commits currently linked to the 53 tickets are all pre-r121473 (good). Is there any new work in trunk that needs to be flagged for merging to 2.1.x?
>>
>> Open tickets
>> There are currently 4 unresolved 2.1-related tickets (ignoring the placeholder release ticket). These either need to be addressed now or punted to the next release. The work associated with creating a new site template (KNL-883) does not appear to have been completed. Is it required for basiclti-2.1?
>>
>> Open
>> https://jira.sakaiproject.org/browse/BLTI-222 (2.1 release ticket)
>> conversion script and test plan commits noted in BLTI-222
>>
>> * https://jira.sakaiproject.org/browse/BLTI-94
>> * https://jira.sakaiproject.org/browse/BLTI-196
>>
>> Awaiting Review
>> * https://jira.sakaiproject.org/browse/BLTI-209
>> * https://jira.sakaiproject.org/browse/KNL-883 (Awaiting review)
>>
>> Changes required in other modules (dependencies)
>> Changes to site-manage and possibly the kernel (please confirm) are required for this release. The following tickets reference commits required in other modules in support of BasicLTI 2.1.
>>
>> https://jira.sakaiproject.org/browse/BLTI-142
>> https://jira.sakaiproject.org/browse/SAK-21763 [in 2.9.x, r104383]
>> https://jira.sakaiproject.org/browse/BLTI-150
>> https://jira.sakaiproject.org/browse/SAK-22335 [in 2.9.x, confirmed]
>> https://jira.sakaiproject.org/browse/BLTI-177
>> https://jira.sakaiproject.org/browse/SAK-22108 [site-manage changes, NOT in 2.9.x]
>> https://jira.sakaiproject.org/browse/BLTI-205
>> site-manage r119500 [site-manage changes, NOT in 2.9.x]
>> https://jira.sakaiproject.org/browse/BLTI-208
>> https://jira.sakaiproject.org/browse/UMICH-781 [reference to conversion script changes]
>> https://jira.sakaiproject.org/browse/BLTI-217
>> https://jira.sakaiproject.org/browse/LSNBLDR-205 [duplicate, ignore]
>> https://jira.sakaiproject.org/browse/BLTI-151
>> depends on https://jira.sakaiproject.org/browse/KNL-879 [not in kernel-1.3.x]
>> KNL-879 is replaced by https://jira.sakaiproject.org/browse/KNL-883 (Awaiting review)
>> see also https://jira.sakaiproject.org/browse/BLTI-154 (open, trunk commit r108832, described as rendering BLTI-151unnecessary)
>> BLTI-154 depends on https://jira.sakaiproject.org/browse/KNL-883
>>
>> Conversion scripts
>> There are conversion script changes noted in 6 tickets. A SAK ticket needs to be created and worked performed in order to add these changes to the /reference module MySQL and Oracle conversion scripts.
>>
>> https://jira.sakaiproject.org/browse/BLTI-222
>> https://jira.sakaiproject.org/browse/BLTI-205
>> https://jira.sakaiproject.org/browse/BLTI-208
>> https://jira.sakaiproject.org/browse/KNL-879 (realm solution, note: replaced by template solution https://jira.sakaiproject.org/browse/KNL-883)
>> https://jira.sakaiproject.org/browse/SAK-21837 (relates to KNL-883)
>> https://jira.sakaiproject.org/browse/SAK-21814 (relates to KNL-879, not in /reference 2.9.x conversion scripts)
>>
>> New properties
>> New properties are noted in 2 tickets. A SAK ticket needs to be created and worked performed in order to add these properties to the /confi module's default.sakai.properties file.
>>
>> https://jira.sakaiproject.org/browse/BLTI-151
>> https://jira.sakaiproject.org/browse/BLTI-203
>>
>> 2.9.x master pom
>> Once all module dependencies are merged to 2.9.x, the master pom <module> entry for BasicLTI needs to be updated to 2.1-SNAPSHOT.
>>
>> <sakai.basiclti.version>2.0.2-SNAPSHOT</sakai.basiclti.version>
>> to
>> <sakai.basiclti.version>2.1-SNAPSHOT</sakai.basiclti.version>
>>
>> basiclti-2.1 base pom
>> The basiclti 2.1.x base pom <parent> needs to be decremented from 2.10-SNAPSHOT to 2.9-SNAPSHOT
>>
>>
>> [1] https://jira.sakaiproject.org/secure/IssueNavigator.jspa?reset=true&mode=hide&jqlQuery=fixVersion+%3D+%222.1.0+%5BTentative%5D%22+AND+project+%3D+BLTI
>
> _______________________________________________
> cle-release-team mailing list
> cle-release-team at collab.sakaiproject.org
> http://collab.sakaiproject.org/mailman/listinfo/cle-release-team
More information about the cle-release-team
mailing list