[cle-release-team] SAK-22619 questions

Aaron Zeckoski azeckoski at unicon.net
Fri Sep 21 09:38:20 PDT 2012


Aren't you just disabling the batch part? It seems like maybe the name
should make that more clear.
Is there a patch on the ticket or commit I can take a look at? I'm out at
the moment but will look when I get back.
-AZ
On Sep 21, 2012 12:16 PM, "Matthew Jones" <matthew at longsight.com> wrote:

> Hi Aaron,
>
> As you suggested, I spent about a half hour on SAK-22619 and got it
> working. I put the check in handleBatch and just made it print an info if
> it was wrong. I created a property "entitybroker.disable.direct" .
>
> https://jira.sakaiproject.org/browse/SAK-22619
>
> Two questions I had though:
>
> 1) Is the name for the property okay? I also set the default to be
> disabled (true)
> 2) I didn't see a bean already for EntityBatchHandler and saw that other
> classes were being passed in from EntityHandlerImpl and didn't want to mess
> up anything, so just used ComponentManger cover. This seem okay? I left the
> spring setter in there though, but didn't count on it being set.
>
> Thanks!
>
> -Matthew
>
> _______________________________________________
> cle-release-team mailing list
> cle-release-team at collab.sakaiproject.org
> http://collab.sakaiproject.org/mailman/listinfo/cle-release-team
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://collab.sakaiproject.org/pipermail/cle-release-team/attachments/20120921/05791e98/attachment-0006.html 


More information about the cle-release-team mailing list