[samigo-team] Auto Submit Job Patch

[Karen Tsao]

Yes. The trunk patch looks good to me too.

Thanks!
Karen






On Wed, Apr 17, 2013 at 11:46 AM, Bryan Holladay <holladay at longsight.com>wrote:

> I have two patches: one for trunk and one for 2.9.x (since they were
> pretty different).  I'd like to apply the changes to both, but at least
> just trunk.  I was working with the latest version of trunk as of 2 days
> ago.  Can I commit?
>
> -Bryan
>
>
> On Wed, Apr 17, 2013 at 2:43 PM, Karen Tsao <ktsao at stanford.edu> wrote:
>
>> Hi Bryan,
>>
>> Your patch looks good to me.
>>
>> Just a question, are you going to apply your changes to 2.9 or trunk? The
>> Auto Submit code in trunk has been modified in SAM-1701.
>>
>> Thanks,
>> Karen
>>
>>
>>
>>
>>
>> On Tue, Apr 16, 2013 at 6:10 AM, Bryan Holladay <holladay at longsight.com>wrote:
>>
>>> Team,
>>>
>>> I have attached a patch to https://jira.sakaiproject.org/browse/SAM-2128
>>>
>>> The issue we've been seeing with the auto submit job is that when there
>>> is a single submission that throws an error, the entire job can not finish
>>> until this is resolved manually in the DB.  The queue will continue to
>>> build up until someone notices it.
>>>
>>> This patch changes the bulk save approach and does an individual save
>>> wrapped in try/catch in order for the job to continue despite a single
>>> submission error.  The bulk approach actually uses a deprecated hibernate
>>> method "saveOrUpdateAll", which Hibernate doesn't recommend using anyways.
>>>
>>> I've tested this locally and this code will end up in a few of our
>>> clients production instances, so we will have a good understanding of it's
>>> impact before the 2.10 release.
>>>
>>> Could someone review this patch or would you just like me to commit it
>>> to trunk myself?
>>>
>>> Thanks,
>>> Bryan
>>>
>>> _______________________________________________
>>> samigo-team mailing list
>>> samigo-team at collab.sakaiproject.org
>>> http://collab.sakaiproject.org/mailman/listinfo/samigo-team
>>>
>>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://collab.sakaiproject.org/pipermail/samigo-team/attachments/20130417/cbf8ded5/attachment.html