[samigo-team] SAM-1591: Students can take a timed assessment after the due date via the url

[Karen Tsao]

Hi Sam,

Your patch looks good. Please go ahead to commit it. Thanks!

Karen

On Tue, Sep 4, 2012 at 10:29 AM, Sam Ottenhoff <ottenhoff at longsight.com>wrote:

> Okay, basic patch to DeliveryBean.java. Any objection for me to commit?
>
> Index:
> src/java/org/sakaiproject/tool/assessment/ui/bean/delivery/DeliveryBean.java
> ===================================================================
> ---
> src/java/org/sakaiproject/tool/assessment/ui/bean/delivery/DeliveryBean.java
>        (revision 112084)
> +++
> src/java/org/sakaiproject/tool/assessment/ui/bean/delivery/DeliveryBean.java
>        (working copy)
> @@ -3023,8 +3023,8 @@
>                 // Not during a Retake
>                 if (actualNumberRetake == numberRetake) {
>                 // If No Late, this is a timed assessment, and not during
> a Retake, go through (see above reason)
> -                       if (!acceptLateSubmission &&
> this.isTimedAssessment()) {
> -                               log.debug("No Late Submission &&
> timedAssessment");
> +                       if (acceptLateSubmission) {
> +                               log.debug("Allowing the late submission by
> the user");
>                         }
>                         else {
>                                 log.debug("noLateSubmission");
>
>
> On Tue, Sep 4, 2012 at 1:20 PM, Keli Sato Amann <kamann at stanford.edu>wrote:
>
>> I could be wrong, Karen may comment more, but I don't think this was
>> intentional on our part, more likely something that got past. In all cases,
>> taking test via URL should behave the same as taking it by accessing via
>> full CLE.
>>
>> Keli
>>
>> ----- Original Message -----
>> From: "Sam Ottenhoff" <ottenhoff at longsight.com>
>> To: "Lynn E. Ward" <leward at iupui.edu>
>> Cc: "Samigo Team" <samigo-team at collab.sakaiproject.org>
>> Sent: Tuesday, September 4, 2012 10:09:39 AM
>> Subject: Re: [samigo-team] SAM-1591: Students can take a timed assessment
>> after the due date via the url
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>> I agree that it would be better to deny access to the assessment. The
>> current behavior is confusing to students.
>>
>>
>>
>>
>> I agree..... does anyone know the origins or the reason for the existing
>> functionality?
>>
>>
>>
>>
>>
>>
>>
>>
>> We have a local patch for this. Megan can probably direct you to the
>> location for the code.
>>
>>
>>
>>
>> I took a look through the oncourse trunk code in msub and see lots of
>> changes to this file, but nothing specifically for this issue:
>>
>>
>>
>> https://source.sakaiproject.org/viewsvn/msub/iu.edu/oncourse/trunk/sam/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/bean/delivery/DeliveryBean.java?view=annotate
>>
>>
>> ==Sam
>> _______________________________________________
>> samigo-team mailing list
>> samigo-team at collab.sakaiproject.org
>> http://collab.sakaiproject.org/mailman/listinfo/samigo-team
>>
>
>
> _______________________________________________
> samigo-team mailing list
> samigo-team at collab.sakaiproject.org
> http://collab.sakaiproject.org/mailman/listinfo/samigo-team
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://collab.sakaiproject.org/pipermail/samigo-team/attachments/20120904/3a8a8863/attachment.html