[samigo-team] Request for code review

[David Horwitz]

Great thanks - I've added a warn line. I took the liberty of also 
committing patches to 2 other identical issues that have been reported 
over the years (they include a warn line)

D

On 04/03/2012 12:39 AM, Karen Tsao wrote:
> Hi David,
>
> Thanks for taking care of this issue. Lydia and I have reviewed you 
> code. She has a suggestion which I am agree too. We'd like to add a 
> warning message before "return null". Do you think this will be useful?
>
> Karen
>
> On Fri, Mar 30, 2012 at 7:21 AM, David Horwitz 
> <david.horwitz at uct.ac.za <mailto:david.horwitz at uct.ac.za>> wrote:
>
>     Hi Gang,
>
>     Could you have a look at the patch on:
>
>     https://jira.sakaiproject.org/browse/SAM-1625
>
>     This prevents a hibernate object not found exception being propagated
>     all the way to the portal error handler. I doubt it fixes the case
>     completetly (i suspect this quizz is still very broken in our instance
>     but it makes the service better behaved). The patch includes a new
>     unit
>     test that tests for this.
>
>     While investigating this I discovered:
>     https://jira.sakaiproject.org/browse/SAM-1636
>
>     Any objections to me cleaning that up too?
>
>     Regards
>
>     David
>
>
>     _______________________________________________
>     samigo-team mailing list
>     samigo-team at collab.sakaiproject.org
>     <mailto:samigo-team at collab.sakaiproject.org>
>     http://collab.sakaiproject.org/mailman/listinfo/samigo-team
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://collab.sakaiproject.org/pipermail/samigo-team/attachments/20120403/1cd116f9/attachment.html