[sakai2-tcc] Feedback on GB Extra Credit minor feature merge into 2.9.x

[Jean-Francois Leveque]

I don't know enough about the change for a +1, but from an i18n quick 
check, I can give at least a 0.

J-F

On 21/06/2013 15:45, Bryan Holladay wrote:
> Sounds good, so good that I just did it:
> http://source.sakaiproject.org/viewsvn?root=svn&view=rev&rev=126079
> <http://source.sakaiproject.org/viewsvn?root=svn&view=rev&rev=126079>
>
> So, is that a +1 now?
>
> -Bryan
>
>
> On Fri, Jun 21, 2013 at 4:21 AM, Jean-Francois Leveque
> <jean-francois.leveque at upmc.fr <mailto:jean-francois.leveque at upmc.fr>>
> wrote:
>
>      > 5.Changes that could impact internationalization negatively must be
>      > tested in two languages that are not variants of the same country.
>      >
>      > a.MMM - I believe this is N/A
>
>     Having two different keys for the same value with which seems the same
>     meaning (no verb/noun difference) is bad.
>
>     Having new values to translate is a small inconvenient I think can be
>     accepted.
>
>     Please simplify the change in
>     http://source.sakaiproject.org/viewsvn/gradebook/trunk/app/ui/src/bundle/org/sakaiproject/tool/gradebook/bundle/Messages.properties?p2=%2Fgradebook%2Ftrunk%2Fapp%2Fui%2Fsrc%2Fbundle%2Forg%2Fsakaiproject%2Ftool%2Fgradebook%2Fbundle%2FMessages.properties&p1=%2Fgradebook%2Ftrunk%2Fapp%2Fui%2Fsrc%2Fbundle%2Forg%2Fsakaiproject%2Ftool%2Fgradebook%2Fbundle%2FMessages.properties&r1=102928&r2=102927&view=diff&pathrev=102928
>     <http://source.sakaiproject.org/viewsvn/gradebook/trunk/app/ui/src/bundle/org/sakaiproject/tool/gradebook/bundle/Messages.properties?p2=%2Fgradebook%2Ftrunk%2Fapp%2Fui%2Fsrc%2Fbundle%2Forg%2Fsakaiproject%2Ftool%2Fgradebook%2Fbundle%2FMessages.properties&p1=%2Fgradebook%2Ftrunk%2Fapp%2Fui%2Fsrc%2Fbundle%2Forg%2Fsakaiproject%2Ftool%2Fgradebook%2Fbundle%2FMessages.properties&r1=102928&r2=102927&view=diff&pathrev=102928>
>     to use only one key for this unique value.
>
>     Otherwise my vote is -1.
>
>     Regards,
>
>     J-F