[sakai2-tcc] Merge SAK-23044 feature into 2.9?

[Matthew Jones]

I think my main question was more of a depreciation/kernel one. The
ContentHostingService api method for setAvailabilty hasn't changed in a
long time since (SAK-5739) however, if the tool sets these properties
without adding an additional parameter to setAvailabilty, it seems like
there will be regressions if other tools (webservices, direct, etc) attempt
to utilize/expose this feature.

Is it preferred to change the api and add an additional parameter, possibly
breaking existing tools eventually if the old method is ever removed and
introduce an api change, which is technically not great for backporting  or
just modify the property in the tool as-is?

I think that makes these features pretty tough and likely to cause
regressions eventually down the road.

This patch seems okay just to be able to get the feature in for 2.9, but I
think we'd want the api change for 2.10+. Any thoughts?


On Thu, Feb 7, 2013 at 3:47 PM, Matthew Jones <matthew at longsight.com> wrote:

> It looks like a good fix, one of the current requirements is such
>
> - The change has been running in production for one month minimum
>
> There are i18n change in the UI so at least the popular variants should
> also be in the properties.
>
> I'd want to test it out a little more to see what this looks like. Hidden
> folders have a different CSS for instructors who can still see it, it seems
> like these should have the same or maybe some different indicator? (Maybe
> it does) This feature has been requested by many of our clients so I think
> we can get it in production somewhere and I can followup on the process.
>
> Some of the code also feels like it could use some additional small
> cleanup.
> Like here, rather than setting properties it should call setAvailabilty
> with a new parameter so webservices can more easily make use of this. I
> prefer the builder pattern over telescoping, but this is what we do in
> Sakai.
>
>
> http://source.sakaiproject.org/viewsvn/content/trunk/content-tool/tool/src/java/org/sakaiproject/content/tool/ListItem.java?p2=%2Fcontent%2Ftrunk%2Fcontent-tool%2Ftool%2Fsrc%2Fjava%2Forg%2Fsakaiproject%2Fcontent%2Ftool%2FListItem.java&p1=%2Fcontent%2Ftrunk%2Fcontent-tool%2Ftool%2Fsrc%2Fjava%2Forg%2Fsakaiproject%2Fcontent%2Ftool%2FListItem.java&r1=117691&r2=117690&view=diff&pathrev=117691
>
> And a method in line with the others to return
>
>   isHiddenWebFolder =
> "true".equals(currentEntity.getProperties().getProperty(ResourceProperties.PROP_HIDDEN_WITH_ACCESSIBLE_CONTENT));
>
> seems nicer. We really could use code review tool on jira!
>
>
> On Thu, Feb 7, 2013 at 3:20 PM, Aaron Zeckoski <azeckoski at unicon.net>wrote:
>
>> I thought that was what I was doing here but if not, can someone who
>> understands the process take over and so I can see an example of it in
>> action?
>> -AZ
>>
>>
>> On Thu, Feb 7, 2013 at 2:52 PM, May, Megan Marie <mmmay at indiana.edu>
>> wrote:
>> > New features for maintenance branches should follow the process
>> outlined at
>> >
>> >
>> https://confluence.sakaiproject.org/display/TCC/Maintenance+Branch+Merge+Policy
>> >
>> > -----Original Message-----
>> > From: sakai2-tcc-bounces at collab.sakaiproject.org [mailto:
>> sakai2-tcc-bounces at collab.sakaiproject.org] On Behalf Of Aaron Zeckoski
>> > Sent: Thursday, February 07, 2013 1:58 PM
>> > To: Sakai 2 Technical Coordination Committee
>> > Subject: [sakai2-tcc] Merge SAK-23044 feature into 2.9?
>> >
>> > TCC members,
>> > I think we should merge https://jira.sakaiproject.org/browse/SAK-23044
>> > into Sakai 2.9. It is a feature which allows a user to hide a folder
>> from viewing while allowing other users to access the files inside it.
>> > Check the ticket for details.
>> > Does anyone have any objections to merging this? Sam would like to get
>> it merged this week if possible.
>> > -AZ
>> >
>> > --
>> > Aaron Zeckoski - Software Architect - http://tinyurl.com/azprofile_______________________________________________
>> > sakai2-tcc mailing list
>> > sakai2-tcc at collab.sakaiproject.org
>> > http://collab.sakaiproject.org/mailman/listinfo/sakai2-tcc
>> > _______________________________________________
>> > sakai2-tcc mailing list
>> > sakai2-tcc at collab.sakaiproject.org
>> > http://collab.sakaiproject.org/mailman/listinfo/sakai2-tcc
>>
>>
>>
>> --
>> Aaron Zeckoski - Software Architect - http://tinyurl.com/azprofile
>> _______________________________________________
>> sakai2-tcc mailing list
>> sakai2-tcc at collab.sakaiproject.org
>> http://collab.sakaiproject.org/mailman/listinfo/sakai2-tcc
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://collab.sakaiproject.org/pipermail/sakai2-tcc/attachments/20130212/80d0a3dc/attachment.html