[sakai2-tcc] new 2.7.2 Blocker: SAK-21104

[Anthony Whyte]

Yes, we have been tracking this one since last week.  Below are earlier emails to Beth, Savitha et al.

Cheers,

Anth


Begin forwarded message:

> From: Anthony Whyte <arwhyte at umich.edu>
> Date: August 25, 2011 9:34:44 PM GMT+01:00
> To: Beth Kirschner <bkirschn at umich.edu>
> Cc: Sam Ottenhoff <ottenhoff at longsight.com>
> Subject: Re: SAK-21071: Regression: Announcements sent out immediately instead of on release date
> 
> Agreed.
> 
> Anth
> 
> 
> On Aug 25, 2011, at 4:32 PM, Beth Kirschner wrote:
> 
>> Anthony,
>> 
>>  If Savitha & Adam can't find a fix within an acceptable time-frame, I'd suggest just rolling the changes back. I'll be off next week, unfortunately, so I wouldn't be able to help much.
>> 
>> - Beth
>> 
>> On Aug 25, 2011, at 4:27 PM, Anthony Whyte wrote:
>> 
>>> Savitha et al--can you take a look at the regression described in SAK-21071.  Though not listed as a blocker for 2.8.1/2.7.2, instructors will be in for a surprise if the announcement tool jumps the gun and issues an email before the intended date/time.
>>> 
>>> Matt suggests that SAK-18641 may have introduced the regression.  If so r93550 was merged to both 2.8.x and 2.7.x and so the regression is currently included in the 2.8.1 and 2.7.2 release branches.
>>> 
>>> cheers,
>>> 
>>> Anth
>>> 
>>> Begin forwarded message:
>>> 
>>>> From: Sam Ottenhoff <ottenhoff at longsight.com>
>>>> Date: August 25, 2011 3:59:54 PM EDT
>>>> To: Matthew Jones <jonespm at umich.edu>
>>>> Cc: "<mt at collab.sakaiproject.org> \(mt at collab.sakaiproject.org\)" <mt at collab.sakaiproject.org>
>>>> Subject: Re: [maint] Regression: Announcements sent out immediately instead of on release date
>>>> 
>>>> Thanks for pointer. That looks like the regression cause.  I filed new bug here:
>>>> 
>>>> https://jira.sakaiproject.org/browse/SAK-21071
>>>> 
>>>> I also am way confused.  Can Adam or Savitha help?  I can work on a patch with a little bit of guidance.
>>>> 
>>>> --Sam
>>>> 
>>>> On Wed, Aug 24, 2011 at 12:38 PM, Matthew Jones <jonespm at umich.edu> wrote:
>>>> Probably a regression from SAK-18641 where the release date in the header was sent to now. :( 
>>>> 
>>>> That's seems like one tricky fix, because from the patch in that SAK, in the UI, it's using the header for the value in the column to sort(s), but in the SiteEmailNotificationAnnc (notify) it's using the header to determine if it needs to send or delay notification sending. I'm don't know enough about announcements though which is why I didn't touch it when I noticed it in the first place. ;)
>>>> 
>>>> -Matthew
>>>> 
>>>> On Tue, Aug 23, 2011 at 8:20 PM, Sam Ottenhoff <ottenhoff at longsight.com> wrote:
>>>> I am testing on Sakai 2.8.x and local trunk, and it looks like announcements with a future release date are being sent out immediately.
>>>> 
>>>> Can anyone else test and confirm on their instance?
>>>> 
>>>> This would be a regression as I believe it worked previously.  Is it still working in 2.7.x?  Any insights out there?
>>>> 
>>>> https://source.sakaiproject.org/viewsvn/announcement/trunk/announcement-impl/impl/src/java/org/sakaiproject/announcement/impl/SiteEmailNotificationAnnc.java?view=log
>>>> 
>>>> 
>>>> --Sam
>>>> 
>>>> _______________________________________________
>>>> mt mailing list
>>>> mt at collab.sakaiproject.org
>>>> http://collab.sakaiproject.org/mailman/listinfo/mt
>>>> 
>>>> 
>>>> 
>>>> _______________________________________________
>>>> mt mailing list
>>>> mt at collab.sakaiproject.org
>>>> http://collab.sakaiproject.org/mailman/listinfo/mt




On Aug 31, 2011, at 3:40 PM, Sam Ottenhoff wrote:

> 2.8.1 is affected.  Here is the bug we have been tracking:
> 
>   https://jira.sakaiproject.org/browse/SAK-21071
> 
> 
> 
> On Wed, Aug 31, 2011 at 10:28 AM, David Horwitz <david.horwitz at uct.ac.za> wrote:
> Hi All,
> 
> Please see:
> https://jira.sakaiproject.org/browse/SAK-21104
> 
> This is a serious regression in 2.7.2  and is a release blocker.
> 
> Summary: if you create an announcement with a future release date but
> select an notification option, the notification is sent immediately.
> 
> I have not tested 2.8.1 so it may also be affected
> 
> Regards
> 
> David
> _______________________________________________
> sakai2-tcc mailing list
> sakai2-tcc at collab.sakaiproject.org
> http://collab.sakaiproject.org/mailman/listinfo/sakai2-tcc
> 
> _______________________________________________
> sakai2-tcc mailing list
> sakai2-tcc at collab.sakaiproject.org
> http://collab.sakaiproject.org/mailman/listinfo/sakai2-tcc

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://collab.sakaiproject.org/pipermail/sakai2-tcc/attachments/20110831/9146d770/attachment.html