[sakai2-tcc] SAK-19326: hybrid removal / patch retention

Aaron Zeckoski aaronz at vt.edu
Mon Oct 18 04:30:31 PDT 2010


-1
Agree with JF that there are things which need to addressed and I feel
like a more thorough code review is warranted.
-AZ


On Mon, Oct 18, 2010 at 4:33 AM, Jean-Francois Leveque
<jean-francois.leveque at upmc.fr> wrote:
> -1 Sorry, but keeping those goes against our goal of quality, AFAICT.
>
> See
> http://collab.sakaiproject.org/pipermail/sakai2-tcc/2010-October/000524.html
>
> Cheers,
>
> J-F
>
> Anthony Whyte a écrit :
>> I've removed the hybrid module assembly dependency from the 2.8.x core-deploy pom as well as the version <property> in the master pom.  I have not reverted the patches to login and providers (SAK-17222, SAK-17223) as myself and others believe retaining the patches will simplify the installation and deployment process for deployers who wish to add hybrid to their 2.8 installations.  There is certainly precedent for this approach; most recently we provided "hooks" for gradebook2 in sakai-2.7.
>>
>> I suggest we leave them in place for inclusion in the upcoming sakai-2.8.0-a02 QA tag.  I believe it important that we avoid erecting barriers to those who wish to pursue the evolving hybrid approach between 2x and the Sakai OAE--removing the patches will add additional steps to those who wish to deploy the hybrid 1.0 module, a scenario that benefits no one.
>>
>> Cheers,
>>
>> Anthony
>>
>>
>> http://jira.sakaiproject.org/browse/SAK-19326
> _______________________________________________
> sakai2-tcc mailing list
> sakai2-tcc at collab.sakaiproject.org
> http://collab.sakaiproject.org/mailman/listinfo/sakai2-tcc
>



-- 
Aaron Zeckoski - Software Engineer - http://tinyurl.com/azprofile


More information about the sakai2-tcc mailing list