[sakai2-tcc] Addition proposal: Shared i18n

[May, Megan Marie]

Hi Jean-Francois, 
     Mostly I was interested in hearing if this idea had been circulated on the dev list since it is cross cutting.  

FWIW, I try to evaluate additions to the software based on facts and data rather than intangible things like trust.

Megan 



-----Original Message-----
From: Jean-Francois Leveque [mailto:jean-francois.leveque at upmc.fr] 
Sent: Tuesday, October 12, 2010 4:21 AM
To: May, Megan Marie
Cc: sakai2-tcc at collab.sakaiproject.org; DAVID ROLDAN MARTINEZ
Subject: Re: [sakai2-tcc] Addition proposal: Shared i18n

Hi Megan,

I won't argue about the lack of review on all commits to trunk because this is related to the lack of community resources. :(

If by vetted, you mean that someone else had a look at it, the answer is no, AFAICT. I's really small and uses the same mechanism as localization in config (which has been in use since 2.6.0), it's only more ambitious. 
This can still be done if someone wants to help with this.

If by vetted, you mean tested by someone else than myself, the answer is no, AFAICT. SAK-16738 is a way to test it, if someone wants to help with this.

I think the possible unforeseen consequences are small, but I might be wrong.

So the lowest risk would be to either get volunteers to review/test it or postpone its use to 2.9.

Would you and the TCC trust me with this one, or should we lower the risk?

J-F

May, Megan Marie a écrit :
> Hi,  
>    Was the i18n repository vetted prior to its addition to trunk?    
> 
> I have to say that I'm hesitant about changing tools to use the repository for  2.8 since so one has used it yet.   There could be unforeseen consequences . . . . .   
> 
> Megan
> 
> -----Original Message-----
> From: sakai2-tcc-bounces at collab.sakaiproject.org 
> [mailto:sakai2-tcc-bounces at collab.sakaiproject.org] On Behalf Of 
> Jean-Francois Leveque
> Sent: Monday, October 11, 2010 6:01 AM
> To: sakai2-tcc at collab.sakaiproject.org
> Subject: [sakai2-tcc] Addition proposal: Shared i18n
> 
> Hi all,
> 
> After Friday's TCC discussion I've added a shared i18n proposal to 
> http://confluence.sakaiproject.org/display/TCC/List+of+Planned+2.8.0+C
> hanges
> 
> This proposal is a way to fix the following issue: lots of default i18n strings are duplicated across the Sakai code and this leads to duplication of translations.
> 
> The goal is to provide shared default strings and their translations that every tool relying on ResourceLoader for i18n can use.
> 
> I've created the i18n repository in config's trunk before the branching (see http://jira.sakaiproject.org/browse/SAK-15037), so this is available in 2.8. It can be considered off because no code in 2.8 currently uses it.
> 
> I've later created a fix using this for
> http://jira.sakaiproject.org/browse/SAK-16738 but it's not merged into
> 2.8 yet.
> 
> My opinion is that such changes are bug fixes and I didn't think I needed to follow the addition proposal process. AFAICT, I was requested to submit this as a proposal. Feel free to quickly ask questions or make comments before a vote is requested.
> 
> I also thought changes such as those in SAK-16738 were small String changes and could still happen between Code and String Freeze. If you think differently, vote against the proposal so I don't hurry to fix things that won't make it into 2.8.
> 
> Cheers,
> 
> J-F