[WG: Sakai QA] [Deploying Sakai] [Building Sakai] Problems making grades visible in Gradebook

[Hedrick Charles]

I've just checked in code that causes Lessons to fix up grade book visibility for items from Samigo and Assignments where Lessons has modified group membership. I've tested it fairly carefully in trunk with mysql. I think I've tested all the paths through the code. I have not tested 2.9 or Oracle, though there's no reason that it would be any different.

I've added a comment to LSNBLDR-249 suggesting ways to test it. It's not going to be easy. This is not the kind of code I'd normally put into something so near release, but not fixing the problem is probably worse.

Note that much of the code is for populating a new field in lesson_builder_groups. I need the siteId in that table to get reasonable performance. I do my own grade book query. It would be nice to have an API call in the grade book to return the external ID's of all external items. I do my own query. I'm reluctant to do the obvious, which is to get all grade book items and look for the external ones. This code appears to be performance-critical, so I want to keep DB access to a minimum. 

Note that this code is not ready for production. There is caching for handling Lessons objects that is disabled, because testing with the cache on a real pain. I'll adjust that right before the last RC.


On Jul 3, 2013, at 9:20:09 AM, Noah Botimer <nbotimer at unicon.net> wrote:

> Hi folks,
> 
> The issue is a little more subtle than described below, but I won't go into too much detail here. What's more important is that I think we have most of a fix implemented:
> 
> https://github.com/botimer/sakai-cle/tree/gb-group
> https://github.com/botimer/sakai-cle/commit/6f36b51cbb90e0daae3d61e135fc00b03a2941a0
> 
> I've talked with Chuck Hedrick about Lessons and there will probably be a resolution to an additional issue there today (which was discussed in another thread).
> 
> There are lots of comments. Please review and provide feedback.
> 
> Zhen, I'd especially like your blessing on the little change to BaseAssignmentService.
> 
> If the approach passes muster, we'll give some implementation advice to contrib tools -- it's a pretty simple addition to the providers, implementing one additional list method. It's in a supplemental interface for now, so it won't accidentally break existing contrib providers, though they will need to implement it for full functionality.
> 
> Thanks,
> -Noah
> 
> On 07/02/2013 08:13 PM, Neal Caidin wrote:
>> Hi All,
>> 
>> Looping in QA and Production.
>> 
>> My understanding is that https://jira.sakaiproject.org/browse/SAK-23733 has the following symptoms:
>> 
>> For Contrib tools which use Groups to integrate with the Gradebook the student cannot see the grade assigned by the instructor and the grade is not included in the Course Grade calculation. 
>> 
>> Same symptoms for the Lessons tool. 
>> 
>> I do not believe that it affects Assignments, Forums, or Test and Quizzes (Samigo).
>> 
>> No ETA for SAK-23733 but it is being actively worked on. Not sure yet if this will be in CLE 2.9.3 or not, but we are a little behind in any case (we have not yet released our first release candidate).
>> 
>> Thanks,
>> 
>> Neal Caidin
>> Sakai CLE Community Coordinator
>> Apereo Foundation
>> 
>> neal.caidin at apereo.org
>> Skype: nealkdin
>> 
>> On Jul 2, 2013, at 6:24 PM, Kevin Takacs <ktakacs at anisakai.com> wrote:
>> 
>>> We ran into the same problem, and I have started working on an ExternalAssignmentProvider implementation for JForum.  I hope to have it completed soon and will contribute it within the next few days.
>>> 
>>> On Tue, Jul 2, 2013 at 1:32 PM, Zhen Qian <zqian at umich.edu> wrote:
>>> Hi, George:
>>> 
>>> If you are running 2.9, I do believe lack of "ExternalAssignmentProvider" impl is the cause of the problem. JForum, same as Test Center, are contrib tools from etudes, and neither implements ExternalAssignmentProvider API. We have patched Test Center locally in UMICH-766.
>>> 
>>> Since people are actively working on SAK-23733 to make ExternalAssignmentProvider impl backward compatible, I would suggest to wait for SAK-23733 patch, instead of writing an impl of ExternalAssignmentProvider in JForum.
>>> 
>>> Thanks,
>>> 
>>> - Zhen
>>> 
>>> 
>>> On Tue, Jul 2, 2013 at 4:16 PM, George Pipkin <gpp8p at virginia.edu> wrote:
>>> Hi - 
>>> 
>>>    We've run into a problem in which a graded Jforum Forum transfers grades to GB, but these grades are not
>>> visible to the students.  I'm wondering if this problem might be related to ExternalAssignmentProvider - is
>>> it implemented in Jforums ?  There's be a bit of discussion about this surrounding SAK-23733.  Since 
>>> the implication of not implementing it might include some impacts on GB grade totals, you can understand
>>> why we at U.Va. are interested in understanding this problem better.
>>> 
>>> 
>>>                                                     - George Pipkin
>>>                                                        U.Va.
>>> 
>>> 
> 
> _______________________________________________
> production mailing list
> production at collab.sakaiproject.org
> http://collab.sakaiproject.org/mailman/listinfo/production
> 
> TO UNSUBSCRIBE: send email to production-unsubscribe at collab.sakaiproject.org with a subject of "unsubscribe"

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://collab.sakaiproject.org/pipermail/sakai-qa/attachments/20130704/19b2decf/attachment.html